From: Daniel Drake <dsd@gentoo.org>
To: John Linville <linville@tuxdriver.com>
Cc: Marc Pignat <marc.pignat@hevs.ch>,
linux-wireless@vger.kernel.org, kune@deine-taler.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zd1211rw, fix oops when ejecting install media
Date: Mon, 15 Oct 2007 12:05:50 +0100 [thread overview]
Message-ID: <4713498E.8040305@gentoo.org> (raw)
In-Reply-To: <200710150851.52995.marc.pignat@hevs.ch>
Marc Pignat wrote:
> The disconnect function can dereference the net_device structure before it is
> allocated. This is the case when ejecting the device installer.
>
> Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
s/before it is allocated/when it is never allocated/
Acked-by: Daniel Drake <dsd@gentoo.org>
> ---
>
> Hello!
>
> Patch against 2.6.23.
> This patch fixes the bug I've submitted to linux-wireless friday in the
> "zd1211rw on 2.6.23 oops ejecting device" thread.
>
> Regards
>
> Marc
>
> --- drivers/net/wireless/zd1211rw/zd_usb.c.orig 2007-10-15 08:29:16.000000000 +0200
> +++ drivers/net/wireless/zd1211rw/zd_usb.c 2007-10-15 08:29:32.000000000 +0200
> @@ -1041,14 +1041,17 @@ error:
> static void disconnect(struct usb_interface *intf)
> {
> struct net_device *netdev = zd_intf_to_netdev(intf);
> - struct zd_mac *mac = zd_netdev_mac(netdev);
> - struct zd_usb *usb = &mac->chip.usb;
> + struct zd_mac *mac;
> + struct zd_usb *usb;
>
> /* Either something really bad happened, or we're just dealing with
> * a DEVICE_INSTALLER. */
> if (netdev == NULL)
> return;
>
> + mac = zd_netdev_mac(netdev);
> + usb = &mac->chip.usb;
> +
> dev_dbg_f(zd_usb_dev(usb), "\n");
>
> zd_netdev_disconnect(netdev);
>
>
next prev parent reply other threads:[~2007-10-15 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 6:51 [PATCH] zd1211rw, fix oops when ejecting install media Marc Pignat
2007-10-15 11:05 ` Daniel Drake [this message]
2007-10-16 6:33 ` Marc Pignat
2007-10-16 13:02 ` Daniel Drake
-- strict thread matches above, loose matches on Subject: below --
2007-10-26 21:04 [PATCH] Add get_unaligned to ieee80211_get_radiotap_len John W. Linville
2007-10-26 21:04 ` [PATCH] Improve sanity checks on injected packets John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: filter locally-originated multicast frames John W. Linville
2007-10-26 21:04 ` [PATCH] libertas: fix endianness breakage John W. Linville
2007-10-26 21:04 ` [PATCH] libertas: more " John W. Linville
2007-10-26 21:04 ` [PATCH] ieee80211: fix TKIP QoS bug John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: reorder association debug output John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: store channel info in sta_bss_list John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: store SSID " John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: honor IW_SCAN_THIS_ESSID in siwscan ioctl John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes John W. Linville
2007-10-26 21:04 ` [PATCH] mac80211: make ieee802_11_parse_elems return void John W. Linville
2007-10-26 21:04 ` [PATCH] zd1201: avoid null ptr access of skb->dev John W. Linville
2007-10-26 21:04 ` [PATCH] ipw2100: send WEXT scan events John W. Linville
2007-10-26 21:04 ` [PATCH] rtl8187: Fix more frag bit checking, rts duration calc John W. Linville
2007-10-26 21:04 ` [PATCH] zd1211rw, fix oops when ejecting install media John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713498E.8040305@gentoo.org \
--to=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marc.pignat@hevs.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).