From: Larry Finger <larry.finger@lwfinger.net>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Adrian Bunk <bunk@kernel.org>,
mb@bu3sch.de, John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value
Date: Mon, 15 Oct 2007 10:03:54 -0500 [thread overview]
Message-ID: <4713815A.3020300@lwfinger.net> (raw)
In-Reply-To: <20071015115936.GP2444@hacking>
WANG Cong wrote:
> Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start()
> in case of returning an uninitialized value.
>
> From: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> drivers/net/wireless/b43/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43legacy/main.c
> +++ linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c
> @@ -3306,7 +3306,7 @@ static int b43legacy_start(struct ieee80
> struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw);
> struct b43legacy_wldev *dev = wl->current_dev;
> int did_init = 0;
> - int err;
> + int err = 0;
>
> mutex_lock(&wl->mutex);
I sent the equivalent patch to John Linville yesterday.
Larry
prev parent reply other threads:[~2007-10-15 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-14 17:51 b43{,legacy}_start can return uninitialized value Adrian Bunk
2007-10-15 11:34 ` [-mm Patch] drivers/net/wireless/b43/main.c: fix an uninitialized variable WANG Cong
2007-10-15 12:56 ` Adrian Bunk
2007-10-15 13:33 ` WANG Cong
2007-10-15 11:59 ` [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value WANG Cong
2007-10-15 15:03 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713815A.3020300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=akpm@osdl.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).