From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mtiwmhc12.worldnet.att.net ([204.127.131.116]:60808 "EHLO mtiwmhc12.worldnet.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754341AbXJOPEX (ORCPT ); Mon, 15 Oct 2007 11:04:23 -0400 Message-ID: <4713815A.3020300@lwfinger.net> (sfid-20071015_160427_891454_C0767B8E) Date: Mon, 15 Oct 2007 10:03:54 -0500 From: Larry Finger MIME-Version: 1.0 To: WANG Cong CC: Adrian Bunk , mb@bu3sch.de, John Linville , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [-mm Patch] drivers/net/wireless/b43legacy/main.c: initialize the correct return value References: <20071014175142.GN4211@stusta.de> <20071015115936.GP2444@hacking> In-Reply-To: <20071015115936.GP2444@hacking> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: WANG Cong wrote: > Initialize "err" in drivers/net/wireless/b43legacy/main.c::b43legacy_start() > in case of returning an uninitialized value. > > From: Adrian Bunk > Signed-off-by: WANG Cong > > --- > drivers/net/wireless/b43/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c > =================================================================== > --- linux-2.6.23-mm1.orig/drivers/net/wireless/b43legacy/main.c > +++ linux-2.6.23-mm1/drivers/net/wireless/b43legacy/main.c > @@ -3306,7 +3306,7 @@ static int b43legacy_start(struct ieee80 > struct b43legacy_wl *wl = hw_to_b43legacy_wl(hw); > struct b43legacy_wldev *dev = wl->current_dev; > int did_init = 0; > - int err; > + int err = 0; > > mutex_lock(&wl->mutex); I sent the equivalent patch to John Linville yesterday. Larry