From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Michael Buesch <mb@bu3sch.de>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [patch] ssb: fix build failure
Date: Mon, 15 Oct 2007 08:14:05 -0700 [thread overview]
Message-ID: <471383BD.1030704@oracle.com> (raw)
In-Reply-To: <20071015151054.GB8343@elte.hu>
Ingo Molnar wrote:
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> That's usually done more like this:
>>
>> depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
>>
>> This allows PCMCIA to be y or m, but if PCMCIA is m, then SSB is
>> restricted to m as well (or n). I.e., PCMCIA = SSB is too strict and
>> not required.
>
> indeed - updated patch below.
>
> Ingo
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
> ------------------>
> From: Ingo Molnar <mingo@elte.hu>
>
> fix build failure if PCMCIA=m but SSB=y:
>
> drivers/built-in.o: In function `ssb_pcmcia_switch_coreidx':
> : undefined reference to `pcmcia_access_configuration_register'
>
> (fix symmetric bug for PCI too.)
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>
> ---
> drivers/ssb/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux/drivers/ssb/Kconfig
> ===================================================================
> --- linux.orig/drivers/ssb/Kconfig
> +++ linux/drivers/ssb/Kconfig
> @@ -22,7 +22,7 @@ config SSB
>
> config SSB_PCIHOST_POSSIBLE
> bool
> - depends on SSB && PCI
> + depends on SSB && (PCI = y || PCI = SSB)
> default y
>
> config SSB_PCIHOST
> @@ -37,7 +37,7 @@ config SSB_PCIHOST
>
> config SSB_PCMCIAHOST_POSSIBLE
> bool
> - depends on SSB && PCMCIA && EXPERIMENTAL
> + depends on SSB && (PCMCIA = y || PCMCIA = SSB) && EXPERIMENTAL
> default y
>
> config SSB_PCMCIAHOST
>
--
~Randy
prev parent reply other threads:[~2007-10-15 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 14:23 [patch] ssb: fix build failure Michael Buesch
2007-10-15 15:06 ` Randy Dunlap
2007-10-15 15:10 ` Ingo Molnar
2007-10-15 15:14 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471383BD.1030704@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).