Re: [ipw3945-devel] [RFC][PATCH] iwlwifi using mac80211_leds

[Ian Schram <ischram@telenet.be>]

Norbert Preining wrote:
> Zhu Yi <yi.zhu@...> writes:
> aven't have enough time to review this patch these days. Will
>> try to do it next week. But any test are always welcome!
> 
> I would like to, is there a way to patch this into the git sources?
the intellinuxwireless.org gits? to make it work it would require an update
of the mac80211 package, and compatibility with older kernels is probably
pretty nasty.

> 
> I am running 2.6.23 with latest iwlwifi git sources.
> 
> I patched the git sources and started compiling with -DCONFIG_IWLWIFI_LEDS=y but
> the compile boiled out with:
> /src/wlan/iwlwifi/foo/compatible/iwl3945-base.c:6218: error: implicit
> declaration of function 'ieee80211_get_assoc_led_name'
> (and some more warnings).
> 
the association led is only in the very latest git sources, i'm guessing only
wireless-2.6 for now.

(also i have learned that i forgot to ifdef the INIT_DELAYED_WORK, I must really try to
beat this inability of sending a patch right the first time round)

i bet an iwl_is_ready(priv) call in the delayed work wouldn't hurt either,
anyway. It works for me feel free to improve it. Or wait until one of
seasoned developers, has no higher priority items on their list.

> Is there anything I can do to test it?
> 
> Best wishes
> 
> Norbert
> 

I'll try to send a patch a bit later today to fix a few of the outstanding issues.