linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH split 0/8] fix 'and' typo's
Date: Fri, 26 Oct 2007 22:06:04 +0200	[thread overview]
Message-ID: <472248AC.7080201@tiscali.nl> (raw)
In-Reply-To: <4722453E.2090801@tiscali.nl>

Roel Kluin wrote:
> A few patches with changes to net code. I have sent these to the lkml
> previously, but they were not yet merged. I am fairly new to kernel 
> programming, so it is possible that I make some mistakes. I'll explain my
> rationale, please nack if incorrect, an additional bit of explanation is
> appreciated even more.
> 
> The condition '!x & y,' does make little sense: the '!' has a higher
> priority than '&'. It behaves therefore like '!x && y'. In the case 
> bitanding flags, however, '!(x & y)' appears to be desired.
> 
> Warning: the change of '!x & y,' to '!(x & y)' may change behavior. if
> not desired, I propose changing this to '!x && y', to make it explicitly
> clear.
> 
> These '&' typo's can be spotted with:
> a="A-Za-z0-9_"
> git-grep "\![^$a()]*[$a]\+\([$a.]*\|->\)*\(\[[$a.]*\]\)\?[ \W]*&[^&]\+"

It was suggested to split this up, so here goes.

  reply	other threads:[~2007-10-26 20:15 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26 19:51 [PATCH] fix 'and' typo's Roel Kluin
2007-10-26 20:06 ` Roel Kluin [this message]
2007-10-26 20:07   ` [PATCH split 1/8] fix 'and' typo's in airo wireless Roel Kluin
2007-10-26 20:09   ` [PATCH split 2/8] fix 'and' typo's in atmel wireless Roel Kluin
2007-10-26 20:12   ` [PATCH split 3/8] fix 'and' typo's in wireless/libertas/wext Roel Kluin
2007-10-26 20:13   ` [PATCH split 4/8] fix 'and' typo's in wireless/p54common Roel Kluin
2007-10-26 20:14   ` [PATCH split 5/8] fix 'and' typo's wireless/prism54/isl_ioctl (first) Roel Kluin
2007-10-29 15:11     ` Luis R. Rodriguez
2007-10-26 20:18   ` [PATCH split 6/8] fix 'and' typo's Roel Kluin
2007-10-26 20:19   ` [PATCH split 7/8] fix 'and' typo's in wireless/zd1211rw/zd_rf_uw2453 Roel Kluin
2007-10-26 20:19   ` [PATCH split 8/8] fix 'and' typo's net/ieee80211/ieee80211_wx Roel Kluin
2008-01-10 19:15   ` [PATCH wireless/arlan] Replace logical- by bit-and Roel Kluin
2008-01-10 20:28     ` Randy Dunlap
2008-01-10 20:48       ` Chuck Ebbert
2008-01-10 21:16         ` Randy Dunlap
2008-01-10 21:28           ` John W. Linville
2008-01-10 22:19       ` Roel Kluin
2007-10-26 23:48 ` [PATCH] fix 'and' typo's Dan Williams
2007-10-27  0:05   ` Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472248AC.7080201@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).