* Regression in latest wireless-2.6: commit 43c8321e breaks rate control
@ 2007-11-07 15:29 Larry Finger
2007-11-07 15:36 ` Johannes Berg
2007-11-07 15:41 ` [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig Johannes Berg
0 siblings, 2 replies; 4+ messages in thread
From: Larry Finger @ 2007-11-07 15:29 UTC (permalink / raw)
To: Johannes Berg, John Linville; +Cc: wireless
Commit 43c8321e breaks rate control, and my b43 device, on wireless-2.6/everything. The hack below
fixes it:
Index: wireless-2.6/net/mac80211/Kconfig
===================================================================
--- wireless-2.6.orig/net/mac80211/Kconfig
+++ wireless-2.6/net/mac80211/Kconfig
@@ -16,7 +16,7 @@ config MAC80211
config MAC80211_RCSIMPLE
bool "'simple' rate control algorithm"
default y
- depends on MAC80211 && EMBEDDED
+ depends on MAC80211
help
This option allows you to turn off the 'simple' rate
control algorithm in mac80211. If you do turn it off,
On my system, the symbol EMBEDDED is not defined, thus rcsimple, the only rate-control mechanism I
need to use, is not built.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Regression in latest wireless-2.6: commit 43c8321e breaks rate control
2007-11-07 15:29 Regression in latest wireless-2.6: commit 43c8321e breaks rate control Larry Finger
@ 2007-11-07 15:36 ` Johannes Berg
2007-11-07 15:41 ` [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig Johannes Berg
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2007-11-07 15:36 UTC (permalink / raw)
To: Larry Finger; +Cc: John Linville, wireless
[-- Attachment #1: Type: text/plain, Size: 979 bytes --]
On Wed, 2007-11-07 at 09:29 -0600, Larry Finger wrote:
> Commit 43c8321e breaks rate control, and my b43 device, on wireless-2.6/everything. The hack below
> fixes it:
>
> Index: wireless-2.6/net/mac80211/Kconfig
> ===================================================================
> --- wireless-2.6.orig/net/mac80211/Kconfig
> +++ wireless-2.6/net/mac80211/Kconfig
> @@ -16,7 +16,7 @@ config MAC80211
> config MAC80211_RCSIMPLE
> bool "'simple' rate control algorithm"
> default y
> - depends on MAC80211 && EMBEDDED
> + depends on MAC80211
> help
> This option allows you to turn off the 'simple' rate
> control algorithm in mac80211. If you do turn it off,
>
> On my system, the symbol EMBEDDED is not defined, thus rcsimple, the only rate-control mechanism I
> need to use, is not built.
Ahrg. I'm stupid. I meant for this to be only selectable on EMBEDDED.
How do I do that?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig
2007-11-07 15:29 Regression in latest wireless-2.6: commit 43c8321e breaks rate control Larry Finger
2007-11-07 15:36 ` Johannes Berg
@ 2007-11-07 15:41 ` Johannes Berg
2007-11-07 16:45 ` Larry Finger
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2007-11-07 15:41 UTC (permalink / raw)
To: Larry Finger; +Cc: John Linville, wireless
I meant for this to be selectable only with EMBEDDED, not enabled only
with EMBEDDED. This does it that way. Sorry.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- everything.orig/net/mac80211/Kconfig 2007-11-07 16:38:57.779051161 +0100
+++ everything/net/mac80211/Kconfig 2007-11-07 16:39:06.949024631 +0100
@@ -14,9 +14,9 @@ config MAC80211
networking stack.
config MAC80211_RCSIMPLE
- bool "'simple' rate control algorithm"
+ bool "'simple' rate control algorithm" if EMBEDDED
default y
- depends on MAC80211 && EMBEDDED
+ depends on MAC80211
help
This option allows you to turn off the 'simple' rate
control algorithm in mac80211. If you do turn it off,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig
2007-11-07 15:41 ` [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig Johannes Berg
@ 2007-11-07 16:45 ` Larry Finger
0 siblings, 0 replies; 4+ messages in thread
From: Larry Finger @ 2007-11-07 16:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, wireless
Johannes Berg wrote:
> I meant for this to be selectable only with EMBEDDED, not enabled only
> with EMBEDDED. This does it that way. Sorry.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/mac80211/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- everything.orig/net/mac80211/Kconfig 2007-11-07 16:38:57.779051161 +0100
> +++ everything/net/mac80211/Kconfig 2007-11-07 16:39:06.949024631 +0100
> @@ -14,9 +14,9 @@ config MAC80211
> networking stack.
>
> config MAC80211_RCSIMPLE
> - bool "'simple' rate control algorithm"
> + bool "'simple' rate control algorithm" if EMBEDDED
> default y
> - depends on MAC80211 && EMBEDDED
> + depends on MAC80211
> help
> This option allows you to turn off the 'simple' rate
> control algorithm in mac80211. If you do turn it off,
This one works here. ACK for non-embedded system.
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-07 16:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-07 15:29 Regression in latest wireless-2.6: commit 43c8321e breaks rate control Larry Finger
2007-11-07 15:36 ` Johannes Berg
2007-11-07 15:41 ` [PATCH] mac80211: fix MAC80211_RCSIMPLE Kconfig Johannes Berg
2007-11-07 16:45 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).