From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: seandarcy2@gmail.com, Bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [RFC/T] b43: Implement the BCM94311MCG rev 02 card with a rev 13 802.11 core
Date: Thu, 15 Nov 2007 17:11:16 -0600 [thread overview]
Message-ID: <473CD214.3060000@lwfinger.net> (raw)
In-Reply-To: <200711152249.12824.mb@bu3sch.de>
Michael Buesch wrote:
> On Thursday 15 November 2007 16:02:48 Larry Finger wrote:
>> It took me a while to figure out where the magic number of 200 came from, and what I needed for the
>> 64-bit case. In fact I think the 200 is a bug and should be 0x200. To me, this change makes it clearer.
>
> The 200 is just a random number.
> I think we don't really care what the value is. (Except zero, which doesn't
> work on some devices).
I think the specs are missing one word and that this quantity should be called "Descriptor Stop
Index" for RX. My understanding is that the RX process uses the descriptors in order until this
particular value is reached. At this point, it restarts at the beginning making a ring buffer. As we
have just allocated 64 slots, it didn't quite seem right to use only the first 25 of them, which is
what the 200 accomplishes. Of course, 25 DMA RX buffers are quite likely to be more than enough. We
might reconsider cutting the allocation number and not take so much DMAable memory. With 64-bit DMA,
all memory is suitable, but not so for the 30-bit cards.
Larry
prev parent reply other threads:[~2007-11-15 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 5:55 [RFC/T] b43: Implement the BCM94311MCG rev 02 card with a rev 13 802.11 core Larry Finger
2007-11-15 10:38 ` Michael Buesch
2007-11-15 15:02 ` Larry Finger
2007-11-15 21:49 ` Michael Buesch
2007-11-15 23:11 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473CD214.3060000@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=seandarcy2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).