From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Sebastian Gottschall <s.gottschall@dd-wrt.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
kvalo@codeaurora.org
Subject: Re: [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter
Date: Wed, 04 Jul 2018 13:12:47 +0200 [thread overview]
Message-ID: <4756311.uatpdkZPGZ@bentobox> (raw)
In-Reply-To: <0cff058a-3c4b-6617-a034-3df706ba3a32@dd-wrt.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Mittwoch, 4. Juli 2018 12:48:06 CEST Sebastian Gottschall wrote:
[...]
> can you explain your request? the macros are unchanged and just
> reformated for maximum line length restriction. the values have been
> taken from QCA's wmi header
You use long shift and mask statements in your patch. But you didn't use the
macros which are there to shorten them. So please check the macros SM and MS
from core.h and adjust your code accordingly. The code which I've pasted does
this (with an unintentionally added a copy and paste error).
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-07-04 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 9:29 [PATCH v8] ath10k: fix crash in recent 3.5.3 9984 firmware due wrong handling of peer_bw_rxnss_override parameter s.gottschall
2018-07-04 10:40 ` Sven Eckelmann
2018-07-04 10:48 ` Sebastian Gottschall
2018-07-04 11:05 ` Sebastian Gottschall
2018-07-04 11:12 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4756311.uatpdkZPGZ@bentobox \
--to=sven.eckelmann@openmesh.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox