From: drago01 <drago01@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: dcbw@redhat.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, jt@hpl.hp.com
Subject: Re: [PATCH] introduce WEXT scan capabilities
Date: Sat, 08 Dec 2007 11:56:46 +0100 [thread overview]
Message-ID: <475A786E.60200@gmail.com> (raw)
In-Reply-To: <20071207.181221.09900510.davem@davemloft.net>
David Miller wrote:
> From: Dan Williams <dcbw@redhat.com>
> Date: Fri, 07 Dec 2007 19:22:46 -0500
>
>
>> @@ -1040,6 +1049,16 @@ struct iw_range
>> * because each entry contain its channel index */
>>
>> __u32 enc_capa; /* IW_ENC_CAPA_* bit field */
>> +
>> + /* Do *NOT* use those fields, they are just used as padding to get
>> + * proper alignement with user space */
>> + __s32 reserved1;
>> + __s32 reserved2;
>> + __u16 reserved3;
>> + __s32 reserved4;
>> + __u32 reserved5;
>> +
>> + __u32 scan_capa; /* IW_SCAN_CAPA_* bit field */
>> };
>>
>> /*
>>
>
> Major NACK. These datastructure usages are complete wrong, and
> we have to stop spreading this problem instead of continuing on
> with it as if it's OK.
>
But it seems like we have to deal with this api until nl80211/cfg80211
is ready. But the situation is _worse_ without this patch (hidden ssid
support is a huge mess).
next prev parent reply other threads:[~2007-12-08 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 0:22 [PATCH] introduce WEXT scan capabilities Dan Williams
2007-12-08 2:12 ` David Miller
2007-12-08 10:56 ` drago01 [this message]
2007-12-09 17:31 ` Dan Williams
2007-12-09 18:34 ` Dave
2007-12-09 18:35 ` Dan Williams
2007-12-10 12:23 ` Johannes Berg
2007-12-10 12:34 ` Johannes Berg
2007-12-10 18:08 ` Jean Tourrilhes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475A786E.60200@gmail.com \
--to=drago01@gmail.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=jt@hpl.hp.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).