From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43: Fix rfkill radio LED
Date: Thu, 13 Dec 2007 09:24:34 -0800 [thread overview]
Message-ID: <47616AD2.8070108@lwfinger.net> (raw)
In-Reply-To: <200712131211.47867.mb@bu3sch.de>
Michael Buesch wrote:
> On Thursday 13 December 2007 06:32:11 Larry Finger wrote:
>> logic in the request_module("rfkill-input") section. Now, the code is
>
> Ehm, no. Wait.
> There was a
> #ifdef CONFIG_RFKILL_INPUT_MODULE
> That is only defined if rfkill-input is a module, right?
Correct and CONFIG_RFKILL_INPUT is defined if the code is built_in. The "most correct" logic for
this section would be:
if (built_in)
all is OK.
if (module)
load it.
If (!built_in && !module)
warn that the LED will not work.
In the version I sent you, the logic is:
if (!built_in) {
load module
if (err)
print message that it will not work
}
To my thinking, the second version is close enough. the only extra step it does is to try to load
the module even when it has not been built, but it does end up with the warning being printed.
Larry
next prev parent reply other threads:[~2007-12-13 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 5:32 [PATCH] b43: Fix rfkill radio LED Larry Finger
2007-12-13 11:11 ` Michael Buesch
2007-12-13 17:24 ` Larry Finger [this message]
2007-12-13 17:58 ` Michael Buesch
-- strict thread matches above, loose matches on Subject: below --
2007-12-13 5:27 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47616AD2.8070108@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).