From: Ehud Gavron <gavron@wetwork.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Larry Finger <larry.finger@lwfinger.net>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] b43: Fix rxheader channel parsing
Date: Wed, 02 Jan 2008 12:37:41 -0700 [thread overview]
Message-ID: <477BE805.9020500@wetwork.net> (raw)
In-Reply-To: <200801022002.58434.mb@bu3sch.de>
Happy New Year, Michael!
:)
Ehud
Michael Buesch wrote:
> On Wednesday 02 January 2008 19:52:08 Larry Finger wrote:
>
>> Michael Buesch wrote:
>>
>>> This patch fixes the parsing of the RX data header channel field.
>>>
>>> The current code parses the header incorrectly and passes a wrong
>>> channel number and frequency for each frame to mac80211.
>>> The FIXMEs added by this patch don't matter for now as the code
>>> where they live won't get executed anyway. They will be fixed later.
>>>
>>> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>>>
>>> ---
>>>
>>> John, as this is a bugfix, it should go into 2.6.24 if still possible.
>>>
>>> Index: wireless-2.6/drivers/net/wireless/b43/xmit.c
>>> ===================================================================
>>> --- wireless-2.6.orig/drivers/net/wireless/b43/xmit.c 2007-12-30 20:30:03.000000000 +0100
>>> +++ wireless-2.6/drivers/net/wireless/b43/xmit.c 2008-01-02 18:13:15.000000000 +0100
>>> @@ -549,21 +549,32 @@ void b43_rx(struct b43_wldev *dev, struc
>>> switch (chanstat & B43_RX_CHAN_PHYTYPE) {
>>> case B43_PHYTYPE_A:
>>> status.phymode = MODE_IEEE80211A;
>>> - status.freq = chanid;
>>> - status.channel = b43_freq_to_channel_a(chanid);
>>> - break;
>>> - case B43_PHYTYPE_B:
>>> - status.phymode = MODE_IEEE80211B;
>>> - status.freq = chanid + 2400;
>>> - status.channel = b43_freq_to_channel_bg(chanid + 2400);
>>> + B43_WARN_ON(1);
>>> + /* FIXME: We don't really know which value the "chanid" contains.
>>> + * So the following assignment might be wrong. */
>>> + status.channel = chanid;
>>> + status.freq = b43_channel_to_freq_5ghz(status.channel);
>>> break;
>>>
>> Shouldn't you just drop this case? No B PHY devices will ever use b43 and the default branch will
>> issue the WARN_ON anyway.
>>
>
> I guess you misread the patch.
>
>
next prev parent reply other threads:[~2008-01-02 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 17:55 [PATCH] b43: Fix rxheader channel parsing Michael Buesch
2008-01-02 18:52 ` Larry Finger
2008-01-02 19:02 ` Michael Buesch
2008-01-02 19:37 ` Ehud Gavron [this message]
2008-01-02 19:52 ` Michael Buesch
2008-01-02 19:47 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477BE805.9020500@wetwork.net \
--to=gavron@wetwork.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).