From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10EFCC4CEC9 for ; Wed, 18 Sep 2019 10:19:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7CF3218AF for ; Wed, 18 Sep 2019 10:19:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="kDIX2fP3"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="M9KYs/TR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729559AbfIRKTA (ORCPT ); Wed, 18 Sep 2019 06:19:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52256 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729482AbfIRKTA (ORCPT ); Wed, 18 Sep 2019 06:19:00 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A18C260741; Wed, 18 Sep 2019 10:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568801938; bh=x5KQoxkKPdpw3obd8l7+AXrpmpoqBbu12IbMaDiZPjw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kDIX2fP3OD9fVQeaZlsH7pAx1wZaPRjyn8RMGVWL7wrzcFiG5SDtXLIZJP32+UjZ0 wKOppnRVydI1VxUbswhlwytdut/uHs+rAD2hVuCc4sPzMvbUbMaA+HqLkEbg65aCNe NSA9eeMs5IFwtYB3OUgvBztkxbfLhWJsS5WlVB4Y= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id ACA066050D; Wed, 18 Sep 2019 10:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1568801937; bh=x5KQoxkKPdpw3obd8l7+AXrpmpoqBbu12IbMaDiZPjw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M9KYs/TR8ntrF+sR1H9IRyfuy4+KWN0+kh2Q3uqRFFi3+Jd6KVYgT1uCSagtzhzLq oI93gUUZbzYVM6kdh0lVk3ybnJj7rgYeJg2kT4OtL0QflhTf1fZ1Tq7UlkIm01LQ3W LqegDn8x2z3addyZbtiwuBgicAgiJAzravYptMFk= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 18 Sep 2019 18:18:56 +0800 From: Yibo Zhao To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Johannes Berg , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode In-Reply-To: <871rwdj4ez.fsf@toke.dk> References: <1568639388-27291-1-git-send-email-yiboz@codeaurora.org> <1568639388-27291-3-git-send-email-yiboz@codeaurora.org> <6684ceecde399edeb31c594f889a403440c78142.camel@sipsolutions.net> <8e4cd872d082c6bce598c87411a2125f@codeaurora.org> <87lfumiq3w.fsf@toke.dk> <595c99a36c4f3e3eb131894d85c09746@codeaurora.org> <871rwdj4ez.fsf@toke.dk> Message-ID: <4780268b967c128a42396c39d697e67e@codeaurora.org> X-Sender: yiboz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-09-18 18:16, Toke Høiland-Jørgensen wrote: > Yibo Zhao writes: > >> On 2019-09-18 05:12, Toke Høiland-Jørgensen wrote: >>> Yibo Zhao writes: >>> >>>> On 2019-09-16 23:27, Johannes Berg wrote: >>>>> Without really looking at the code - >>>>> >>>>>> If station is ineligible for transmission in >>>>>> ieee80211_txq_may_transmit(), >>>>>> no packet will be delivered to FW. During the tests in push-pull >>>>>> mode >>>>>> with >>>>>> many clients, after several seconds, not a single station is an >>>>>> eligible >>>>>> candidate for transmission since global time is smaller than all >>>>>> the >>>>>> station's virtual airtime. As a consequence, the Tx has been >>>>>> blocked >>>>>> and >>>>>> throughput is quite low. >>>>> >>>>> You should rewrite this to be, erm, a bit more understandable in >>>>> mac80211 context. I assume you're speaking (mostly?) about ath10k, >>>>> but >>>>> I >>>>> have very little context there. "push pull mode"? "firmware"? These >>>>> things are not something mac80211 knows about. >>>> Hi Johannes, >>>> >>>> Thanks for your kindly reminder. Will rewrite the commit log. >>>> >>>>> >>>>>> Co-developed-by: Yibo Zhao >>>>> >>>>> That also seems wrong, should be Toke I guess, unless you intended >>>>> for >>>>> a >>>>> From: Toke to be present? >>>> Do you mean it should be something like: >>>> >>>> Co-developed-by: Toke Høiland-Jørgensen >>>> Signed-off-by: Yibo Zhao >>>> Signed-off-by: Toke Høiland-Jørgensen >>>> >>>> Am I understanding right? >>> >>> I think the right thing here, as with the previous patch, is to just >>> drop my sign-off; you're writing this patch, and I'll add ack/reviews >>> as >>> appropriate. And in that case, well, no need to have co-developed-by >>> yourself when your name is on the patch as author :) >>> >>> -Toke >> Sorry, I think I have missed checking your reply, please ignore the >> wrong signed-off in PATCH-V2. > > While you're re-spinning, could you please add a changelog for the > changes you make? Makes it easier to keep track :) > > You can add a cover-letter with a full changelog instead of having a > separate changelog for each patch; that's what I usually do... > > -Toke Sure, thanks. -- Yibo