From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFT] b43: Add support for new firmware
Date: Fri, 11 Jan 2008 09:40:04 -0700 [thread overview]
Message-ID: <47879BE4.7040108@lwfinger.net> (raw)
In-Reply-To: <200801102046.56979.mb@bu3sch.de>
Michael Buesch wrote:
> This patch adds support for new firmware.
> Please test this on old and new firmware.
I have tested this patch with old firmware. It seems to work; however my testing is not complete as
my computer has started hanging with the "Caps Lock" light flashing. The crash is not caused by this
patch as it happened with 2.6.24-rc5, which has run for many days. I do have a suggestion for
changing the patch (see below).
> +static inline
> +size_t b43_txhdr_size(struct b43_wldev *dev)
> +{
> + if (b43_is_old_txhdr_format(dev))
> + return 100 + sizeof(struct b43_plcp_hdr6);
> + return 104 + sizeof(struct b43_plcp_hdr6);
> +}
Why not eliminate most of the magic numbers in this part with
size_t b43_txhdr_size(struct b43_wldev *dev)
{
if (b43_is_old_txhdr_format(dev))
return sizeof(struct b43_txhdr) - 4;
return sizeof(struct b43_txhdr);
}
Larry
next prev parent reply other threads:[~2008-01-11 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 19:46 [PATCH RFT] b43: Add support for new firmware Michael Buesch
2008-01-11 16:40 ` Larry Finger [this message]
2008-01-11 16:43 ` Martin Marques
2008-01-11 17:17 ` Larry Finger
2008-01-11 16:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47879BE4.7040108@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).