Re: [RFC] mac80211: add rate to ieee80211_tx_status

[Felix Fietkau <nbd@openwrt.org>]

Johannes Berg wrote:
> I thought we just agreed not to because they're not bit rate but rather
> rate control specific. Think of it this way: the rate control algorithm
> selects a bitrate and those control flags you mentioned (SISO/MIMO/...),
> right?
> 
> So the rate control algorithm has to communicate the bitrate and the flags
> to the hardware. It currently communicates the bitrate selection by giving
> a bitrate structure pointer (it could simply give the bitrate in kbps or
> whatever but that would mean the driver needs to look up its hw_value so
> this is the reason for passing the pointer) and cannot currently
> communicate the control flags selection.
> 
> So the way I see it we'd add something like "u32 rate_control_flags" to
> struct tx_control for the flags you wanted, and also add a similar field
> (to be able to reuse the flag definitions) to the tx status & rx status
> structs. It seems to me that makes most sense, no?
I'd like to have multiple rates in the tx status, including the number of
attempts for each rate. The Minstrel rate control needs these to build its
statistics properly.

- Felix