Kernel panic after insmodding rtl8187

Kernel panic after insmodding rtl8187

[Hauke Mehrtens]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

Hi

With the newest version of rtl8187 (out of compat-wireless) I get a
kernel panic after insmodding it.

I can't read the full error message, but the last lines  are looking
like this.

Loading the driver without having an realtek wireless device at the PC
is working normal.

I am using kernel 2.6.24 on Ubuntu AMD64 the rtl8187 chip is on an Asus
P5D Deluxe Wifi board.

I had the same kernel panic with wireless-2.6 everything from ~8.2.2008.

If you need more information please tell me what to do.

[<ffffffff8040a34f>] __qdisc_run+0x15f/0x200
[<ffffffff803fc02e>] dev_queue_xmit+0x20e/0x330
[<ffffffff88df54d9>] :mac80211:ieee80211_sta_scan_work+0x119/0x200
[<ffffffff88df53c0>] :mac80211:ieee80211_sta_scan_work+0x0/0x200
[<ffffffff8024c9df>] run_workqueue+0x7f/0x110
[<ffffffff8024d580>] worker_thread+0x0/0x130
[<ffffffff8024d645>] worker_thread+0xc5/0x130
[<ffffffff802510e0>] autoremove_wake_function+0x0/0x30
[<ffffffff8024d580>] worker_thread+0x0/0x130
[<ffffffff8024d580>] worker_thread+0x0/0x130
....

Code: 0f b7 40 06 89 cb 80 cf 80 c1 e0 13 09 c3 49 8b 46 08 0f b7
RIP [<ffffffff88e28255>] :rtl8187:rtl8187_tx+0x55/0x1e0
RSP [<ffff81014333fc80>]
CR2 0000000000000006

Kernel panic - not syncing: Aiee, killing interrupt handler!
-- 
Mit freundlichen Grüßen

Hauke Mehrtens


Hauke Mehrtens
Westpreußenweg 10
27442 Gnarrenburg
Tel.  : 04763/1745
Mobil : 0151/10778862
ICQ   : 160871207
Web   : www.hauke-m.de



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 890 bytes --]

Re: Kernel panic after insmodding rtl8187

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]


> If you need more information please tell me what to do.

Do you have a powerpc machine where you can put in the card? ;)

In any case, we need whatever came *before* that stack trace. Got a
serial console or even digital camera?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Kernel panic after insmodding rtl8187

[Hauke Mehrtens]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

Hi

I have no powerpc machine and no serial console so I mad a picture with
my cell phone.
http://www.hauke-m.de/fileadmin/rtl-wifi/kernel-panic-2008-02-17.JPG

The error appears when starting the wireless network with "ifup wlan0".
The insmodding works without any error.

The picture was made on a up to date wireless-testing kernel.

The errors after doing ifup are also printed on an vanilla 2.6.24
kernel, where the module is working.

It is an AMD64 System with a x64_32 kernel on Ubuntu Gutsy
--
Hauke Mehrtens

Johannes Berg schrieb:
>> If you need more information please tell me what to do.
> 
> Do you have a powerpc machine where you can put in the card? ;)
> 
> In any case, we need whatever came *before* that stack trace. Got a
> serial console or even digital camera?
> 
> johannes


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 890 bytes --]

Re: Kernel panic after insmodding rtl8187

[Johannes Berg]

> http://www.hauke-m.de/fileadmin/rtl-wifi/kernel-panic-2008-02-17.JPG
> 
> The error appears when starting the wireless network with "ifup wlan0".
> The insmodding works without any error.

Thanks, I think this patch will fix it.

johannes

--- everything.orig/drivers/net/wireless/rtl8187_dev.c	2008-02-18 12:19:40.070030491 +0100
+++ everything/drivers/net/wireless/rtl8187_dev.c	2008-02-18 12:20:44.290028429 +0100
@@ -176,12 +176,16 @@ static int rtl8187_tx(struct ieee80211_h
 
 	flags = skb->len;
 	flags |= RTL8187_TX_FLAG_NO_ENCRYPT;
-	flags |= control->rts_cts_rate->hw_value << 19;
+
+	BUG_ON(!control->tx_rate);
+
 	flags |= control->tx_rate->hw_value << 24;
 	if (ieee80211_get_morefrag((struct ieee80211_hdr *)skb->data))
 		flags |= RTL8187_TX_FLAG_MORE_FRAG;
 	if (control->flags & IEEE80211_TXCTL_USE_RTS_CTS) {
+		BUG_ON(!control->rts_cts_rate);
 		flags |= RTL8187_TX_FLAG_RTS;
+		flags |= control->rts_cts_rate->hw_value << 19;
 		rts_dur = ieee80211_rts_duration(dev, priv->vif,
 						 skb->len, control);
 	}

Re: Kernel panic after insmodding rtl8187

[David G Hamblen]

With this patch, the rtl8187 driver from origin/everything (2.6.25-rc1) 
seems to work well for the first time.  Previous versions sometimes 
worked, but were slow on download speeds (~2.5MB/s vs >4MB/s) compared 
to my old MA401 card.



Johannes Berg wrote:
>> http://www.hauke-m.de/fileadmin/rtl-wifi/kernel-panic-2008-02-17.JPG
>>
>> The error appears when starting the wireless network with "ifup wlan0".
>> The insmodding works without any error.
> 
> Thanks, I think this patch will fix it.
> 
> johannes
> 
> --- everything.orig/drivers/net/wireless/rtl8187_dev.c	2008-02-18 12:19:40.070030491 +0100
> +++ everything/drivers/net/wireless/rtl8187_dev.c	2008-02-18 12:20:44.290028429 +0100
> @@ -176,12 +176,16 @@ static int rtl8187_tx(struct ieee80211_h
>  
>  	flags = skb->len;
>  	flags |= RTL8187_TX_FLAG_NO_ENCRYPT;
> -	flags |= control->rts_cts_rate->hw_value << 19;
> +
> +	BUG_ON(!control->tx_rate);
> +
>  	flags |= control->tx_rate->hw_value << 24;
>  	if (ieee80211_get_morefrag((struct ieee80211_hdr *)skb->data))
>  		flags |= RTL8187_TX_FLAG_MORE_FRAG;
>  	if (control->flags & IEEE80211_TXCTL_USE_RTS_CTS) {
> +		BUG_ON(!control->rts_cts_rate);
>  		flags |= RTL8187_TX_FLAG_RTS;
> +		flags |= control->rts_cts_rate->hw_value << 19;
>  		rts_dur = ieee80211_rts_duration(dev, priv->vif,
>  						 skb->len, control);
>  	}
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html