* [PATCH] wireless: Convert to list_for_each_entry_rcu()
@ 2008-02-19 0:47 Roel Kluin
2008-02-19 14:41 ` Roel Kluin
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-02-19 0:47 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lkml
Please verify, this patch was not yet tested.
---
Convert list_for_each_rcu() to list_for_each_entry_rcu()
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/wireless/strip.c b/drivers/net/wireless/strip.c
index 88efe1b..c5aaab8 100644
--- a/drivers/net/wireless/strip.c
+++ b/drivers/net/wireless/strip.c
@@ -963,11 +963,12 @@ static char *time_delta(char buffer[], long time)
static struct strip *strip_get_idx(loff_t pos)
{
struct list_head *l;
+ struct strip *str;
int i = 0;
- list_for_each_rcu(l, &strip_list) {
+ list_for_each_entry_rcu(str, l, &strip_list, list) {
if (pos == i)
- return list_entry(l, struct strip, list);
+ return str;
++i;
}
return NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] wireless: Convert to list_for_each_entry_rcu()
2008-02-19 0:47 [PATCH] wireless: Convert to list_for_each_entry_rcu() Roel Kluin
@ 2008-02-19 14:41 ` Roel Kluin
0 siblings, 0 replies; 2+ messages in thread
From: Roel Kluin @ 2008-02-19 14:41 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, lkml
Roel Kluin wrote:
> Please verify, this patch was not yet tested.
> ---
> Convert list_for_each_rcu() to list_for_each_entry_rcu()
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
Same mistake as in other patch, please ignore the previous patch
and consider the patch below.
---
Convert list_for_each_rcu() to list_for_each_entry_rcu()
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/wireless/strip.c b/drivers/net/wireless/strip.c
index 88efe1b..bced3fe 100644
--- a/drivers/net/wireless/strip.c
+++ b/drivers/net/wireless/strip.c
@@ -962,12 +962,12 @@ static char *time_delta(char buffer[], long time)
/* get Nth element of the linked list */
static struct strip *strip_get_idx(loff_t pos)
{
- struct list_head *l;
+ struct strip *str;
int i = 0;
- list_for_each_rcu(l, &strip_list) {
+ list_for_each_entry_rcu(str, &strip_list, list) {
if (pos == i)
- return list_entry(l, struct strip, list);
+ return str;
++i;
}
return NULL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-19 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-19 0:47 [PATCH] wireless: Convert to list_for_each_entry_rcu() Roel Kluin
2008-02-19 14:41 ` Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).