[PATCH] b43legacy: fix bcm4303 crash

[PATCH] b43legacy: fix bcm4303 crash

[Stefano Brivio]

This fixes an hard crash which happened upon driver loading on bcm4303 rev.
2 devices.

Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
---
John, this is for 2.6.26.
---
diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index e123719..4bc0e8b 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
 		goto out;
 
 	cc = &bus->chipco;
+
+	if (!cc->dev)
+		goto out;
+	if (cc->dev->id.revision < 5)
+		goto out;
+
 	ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
 	err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
 	if (err)


--
Ciao
Stefano

Re: [PATCH] b43legacy: fix bcm4303 crash

[Michael Buesch]

On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:
> This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> 2 devices.
> 
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>

ACK

> ---
> John, this is for 2.6.26.

Why not 2.6.25?

> ---
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index e123719..4bc0e8b 100644
> --- a/drivers/ssb/main.c
> +++ b/drivers/ssb/main.c
> @@ -1101,6 +1101,12 @@ int ssb_bus_may_powerdown(struct ssb_bus *bus)
>  		goto out;
>  
>  	cc = &bus->chipco;
> +
> +	if (!cc->dev)
> +		goto out;
> +	if (cc->dev->id.revision < 5)
> +		goto out;
> +
>  	ssb_chipco_set_clockmode(cc, SSB_CLKMODE_SLOW);
>  	err = ssb_pci_xtal(bus, SSB_GPIO_XTAL | SSB_GPIO_PLL, 0);
>  	if (err)
> 
> 
> --
> Ciao
> Stefano
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
> 
> 



-- 
Greetings Michael.

Re: [PATCH] b43legacy: fix bcm4303 crash

[Stefano Brivio]

On Sun, 6 Apr 2008 17:20:02 +0200
Michael Buesch <mb@bu3sch.de> wrote:

> On Sunday 06 April 2008 17:05:07 Stefano Brivio wrote:
> > This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> > 2 devices.
> > 
> > Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
> 
> ACK
> 
> > ---
> > John, this is for 2.6.26.
> 
> Why not 2.6.25?

Sorry, typo. Yes, i meant 2.6.25.


--
Ciao
Stefano

Re: [PATCH] b43legacy: fix bcm4303 crash

[Larry Finger]

Stefano Brivio wrote:
> This fixes an hard crash which happened upon driver loading on bcm4303 rev.
> 2 devices.
> 
> Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
> ---
> John, this is for 2.6.26.

Shouldn't this be for 2.6.25?

Larry