linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Pavel Roskin <proski@gnu.org>
Subject: Re: [PATCH] Add Realtek 8187B support
Date: Thu, 10 Apr 2008 23:57:50 -0500	[thread overview]
Message-ID: <47FEEFCE.6040006@lwfinger.net> (raw)
In-Reply-To: <200804100143.32854.herton@mandriva.com.br>

Herton Ronaldo Krzesinski wrote:
> 
> Can you open your dongle and see if you really have a RTL8187B? (as you
> said you had to force the ID). May be it wasn't really a 8187b device but
> another variant. I did many tests this week with a 8187b that continues to
> work ok.

I don't want to open it as it should still be under warranty. I'm
pretty sure it is an 8187b. When I tried it with the 8187 driver, it
gets an rf calibration error. By using your driver with the patch
below, it loaded and worked, at least for a while. It probably was a
natural death, but I felt I should issue a warning, jest in case.

I was going to hold the following patch until I had more to 
contribute; however, I don't know if I will be able to participate. 
Please apply the patch, as it lets devices like mine, where the 
iProduct string identifies is as an RTL8187B device, but the idProduct 
value is 0x8187, not 0x8189.

Thanks,

Larry

Index: wireless-testing/drivers/net/wireless/rtl8187_dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl8187_dev.c
+++ wireless-testing/drivers/net/wireless/rtl8187_dev.c
@@ -946,7 +946,8 @@ static int __devinit rtl8187_probe(struc
  	}

  	priv = dev->priv;
-       priv->is_rtl8187b = (id->driver_info == DEVICE_RTL8187B);
+	priv->is_rtl8187b = (id->driver_info == DEVICE_RTL8187B) ||
+			    !memcmp(udev->product, "RTL8187B", 8);

  	SET_IEEE80211_DEV(dev, &intf->dev);
  	usb_set_intfdata(intf, dev);




  reply	other threads:[~2008-04-11  4:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-08 22:31 [PATCH] Add Realtek 8187B support Herton Ronaldo Krzesinski
2008-04-09  4:22 ` Pavel Roskin
2008-04-09 17:36   ` Herton Ronaldo Krzesinski
2008-04-09 18:59     ` Pavel Roskin
2008-04-09  6:31 ` Pavel Roskin
2008-04-09 18:07   ` Herton Ronaldo Krzesinski
2008-04-09 23:31     ` Herton Ronaldo Krzesinski
2008-04-09 15:46 ` Larry Finger
2008-04-09 18:12   ` Herton Ronaldo Krzesinski
2008-04-10  3:39 ` Larry Finger
2008-04-10  4:43   ` Herton Ronaldo Krzesinski
2008-04-11  4:57     ` Larry Finger [this message]
2008-04-12  2:36       ` Herton Ronaldo Krzesinski
2008-04-12 17:29         ` Pavel Roskin
2008-04-12 22:49           ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47FEEFCE.6040006@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=herton@mandriva.com.br \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).