From: Hauke Mehrtens <hauke@hauke-m.de>
To: lrodriguez@atheros.com
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: compat-wireless-2008-04-20 doesn't build on kernel 2.6.23
Date: Sun, 20 Apr 2008 18:02:50 +0200 [thread overview]
Message-ID: <480B692A.5010703@hauke-m.de> (raw)
In-Reply-To: <480B6117.3000201@hauke-m.de>
[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]
The attached patch solves the first problem in ath5k.
--
Hauke
Hauke Mehrtens schrieb:
> I have tested to build compat-wireless-2008-04-20 on kernel 2.6.23 but
> it doesn't build. I got the following error:
>
> CC [M] compat-wireless-2008-04-20/drivers/net/wireless/ath5k/hw.o
> compat-wireless-2008-04-20/drivers/net/wireless/ath5k/hw.c: In function
> 'ath5k_hw_attach':
> compat-wireless-2008-04-20/drivers/net/wireless/ath5k/hw.c:346: error:
> 'struct pci_dev' has no member named 'is_pcie'
> make[4]: *** compat-wireless-2008-04-20/drivers/net/wireless/ath5k/hw.o]
> Error 1
> make[3]: *** compat-wireless-2008-04-20/drivers/net/wireless/ath5k] Error 2
> make[2]: *** compat-wireless-2008-04-20/drivers/net/wireless] Error 2
> make[1]: ***
> [_module_/home/hmehr/compat-wireless/compat-wireless-2008-04-20] Error 2
> make[1]: Leaving directory `/usr/src/kernels/2.6.23.15-80.fc7-x86_64'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: compat-wireless-2.6.diff --]
[-- Type: text/x-diff; name="compat-wireless-2.6.diff", Size: 899 bytes --]
diff --git a/compat/compat.diff b/compat/compat.diff
index 38f5191..48701f1 100644
--- a/compat/compat.diff
+++ b/compat/compat.diff
@@ -349,6 +349,18 @@
};
--- a/drivers/net/wireless/ath5k/hw.c 2008-03-14 10:32:35.000000000 -0400
+++ b/drivers/net/wireless/ath5k/hw.c 2008-03-14 10:32:36.000000000 -0400
+@@ -343,7 +343,11 @@
+ * I guess these point to ClockReq but
+ * i'm not sure.)
+ */
++#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,24))
++ if ((ah->ah_version == AR5K_AR5212) && (compat_is_pcie(pdev)) {
++#else
+ if ((ah->ah_version == AR5K_AR5212) && (pdev->is_pcie)) {
++#endif
+ ath5k_hw_reg_write(ah, 0x9248fc00, 0x4080);
+ ath5k_hw_reg_write(ah, 0x24924924, 0x4080);
+ ath5k_hw_reg_write(ah, 0x28000039, 0x4080);
@@ -385,7 +385,11 @@
/* reseting PCI on PCI-E cards results card to hang
* and always return 0xffff... so we ingore that flag
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 890 bytes --]
next prev parent reply other threads:[~2008-04-20 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 15:28 compat-wireless-2008-04-20 doesn't build on kernel 2.6.23 Hauke Mehrtens
2008-04-20 16:02 ` Hauke Mehrtens [this message]
2008-04-21 22:07 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480B692A.5010703@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).