Re: prism54 regression in current -git

[Patrick McHardy <kaber@trash.net>]

Luis R. Rodriguez wrote:
>> Good catch. The carrier is set upon a firmware trigger so it is
>> possible that when in AP mode we don't hit the trigger in firmware. I
>> left open the possibility for this happening and go figure it happens.
>> Even if we had docs this probably wouldn't be documented :) I'll try
>> to cook up an exception patch now.
> 
> Let me know if this fixes it.
> 
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> 
> diff --git a/drivers/net/wireless/prism54/islpci_dev.c b/drivers/net/wireless/prism54/islpci_dev.c
> index 04c2638..9196825 100644
> --- a/drivers/net/wireless/prism54/islpci_dev.c
> +++ b/drivers/net/wireless/prism54/islpci_dev.c
> @@ -388,8 +388,15 @@ islpci_open(struct net_device *ndev)
>  
>  	netif_start_queue(ndev);
>  
> -	/* Turn off carrier unless we know we have associated */
> -	netif_carrier_off(ndev);
> +	/* Turn off carrier if in STA or Ad-hoc mode. It will be turned on
> +	 * once the firmware receives a trap of being associated
> +	 * (GEN_OID_LINKSTATE). In other modes (AP or WDS or monitor) we
> +	 * should just leave the carrier on as its expected the firmware
> +	 * won't send us a trigger. */
> +	if (priv->iw_mode == IW_MODE_INFRA || priv->iw_mode == IW_MODE_ADHOC)
> +		netif_carrier_off(ndev);
> +	else
> +		netif_carrier_on(ndev);
>  
>  	return 0;
>  }
> 

This will probably fix the error I'm seeing, but if I'm not
mistaken the mode can be changed while the device is UP and
this case is not handled by your patch.