From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs
Date: Fri, 13 Jun 2008 09:50:05 -0500 [thread overview]
Message-ID: <4852891D.10600@lwfinger.net> (raw)
In-Reply-To: <200806131047.33710.mb@bu3sch.de>
Michael Buesch wrote:
> From: Larry.Finger@lwfinger.net
>
> In current ssb-sprom code, the Subsystem and Product ID's are wrong for rev 4
> SPROM's.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> ---
>
> John, this is a bugfix for 2.6.26.
>
>
> Index: ssb_sprom/ssb_sprom.h
> ===================================================================
> --- ssb_sprom.orig/ssb_sprom.h
> +++ ssb_sprom/ssb_sprom.h
> @@ -33,10 +33,10 @@
>
> /* byte offsets */
> #define SPROM_SUBP (0x02 * 2)
> -#define SPROM4_SUBP (0x00 * 2)
> +#define SPROM4_SUBP (0x02 * 2)
> #define SPROM_SUBV (0x03 * 2)
> #define SPROM_PPID (0x04 * 2)
> -#define SPROM4_PPID (0x02 * 2)
> +#define SPROM4_PPID (0x04 * 2)
> #define SPROM_BFLHI (0x1C * 2)
> #define SPROM_IL0MACADDR (0x24 * 2)
> #define SPROM_ET0MACADDR (0x27 * 2)
>
The patch is for ssb-sprom, not ssb. If I still have any of my feeble
mind left, ssb-sprom has not become part of the kernel. John, you can
ignore this patch.
Larry
next prev parent reply other threads:[~2008-06-13 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-13 8:47 [PATCH] ssb: Fix for incorrect Subsystem and PCI Product IDs on rev 4 SPROMs Michael Buesch
2008-06-13 14:50 ` Larry Finger [this message]
2008-06-13 14:56 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4852891D.10600@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).