linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
	bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ssb, b43, b43legacy, b44: Rewrite SSB DMA API
Date: Fri, 20 Jun 2008 19:05:38 -0500	[thread overview]
Message-ID: <485C45D2.1050106@lwfinger.net> (raw)
In-Reply-To: <200806201150.29497.mb@bu3sch.de>

Michael Buesch wrote:
> This is a rewrite of the DMA API for SSB devices.
> This is needed, because the old (non-existing) "API" made too many bad
> assumptions on the API of the host-bus (PCI).
> This introduces an almost complete SSB-DMA-API that maps to the lowlevel
> bus-API based on the bustype.
> 
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> 

Is there a pre-requisite for this patch? I tried to apply it to 
wireless-testing with version v2.6.26-rc6-10526-ga0d3022. Hunk 4 of 
the patch for drivers/net/wireless/b43legacy/dma.c failed due to a 
line missing from the original source:

> @@ -891,39 +890,39 @@ struct b43legacy_dmaring *b43legacy_setu

--snip--

> +		ssb_dma_unmap_single(dev->dev, dma_test,
> +				     sizeof(struct b43legacy_txhdr_fw3),
> +				     DMA_TO_DEVICE);
>  	}
>  
	ring->dev = dev;     <-------------- This line missing.
>  	ring->nr_slots = nr_slots;
>  	ring->mmio_base = b43legacy_dmacontroller_base(type, controller_index);
>  	ring->index = controller_index;
>  	if (type == B43legacy_DMA_64BIT)

Larry

  parent reply	other threads:[~2008-06-21  0:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-20  9:50 [PATCH] ssb, b43, b43legacy, b44: Rewrite SSB DMA API Michael Buesch
2008-06-20 10:41 ` Michael Buesch
2008-06-21  0:05 ` Larry Finger [this message]
2008-06-21  9:30   ` Michael Buesch
2008-07-03 16:30 ` Felipe Maya
2008-07-03 20:52   ` Michael Buesch
2008-07-03 21:07     ` Michael Buesch
2008-07-08 15:58     ` Steve Brown
2008-07-08 17:04       ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=485C45D2.1050106@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).