From: Maxim Levitsky <maximlevitsky@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: drago01 <drago01@gmail.com>,
linux-wireless@vger.kernel.org, Zhu Yi <yi.zhu@intel.com>,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [ipw3945-devel] [BUG] iwlwifi 3945 works only with disable_hw_scan=1
Date: Tue, 24 Jun 2008 23:32:01 +0300 [thread overview]
Message-ID: <486159C1.2070000@gmail.com> (raw)
In-Reply-To: <20080624194714.GA11664@tuxdriver.com>
John W. Linville wrote:
> On Wed, Jun 18, 2008 at 10:28:04AM +0200, drago01 wrote:
>>>>> Please try this one
>>>>>
>>>>> --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
>>>>> +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
>>>>> @@ -3348,7 +3348,10 @@ static void
>>>>> iwl3945_rx_scan_complete_notif(struct iwl3945_priv *priv,
>>>>>
>>>>> /* Remove this scanned band from the list
>>>>> * of pending bands to scan */
>>>>> - priv->scan_bands--;
>>>>> + if (priv->cfg->sku & IWL_SKU_A)
>>>>> + priv->scan_bands--;
>>>>> + else
>>>>> + priv->scan_bands = 0;
>>>>>
>>>>>
>>>>
>>>> I tested this patch, and it fixes this issue, Thanks a lot.
>>>>
>>> Thanks a lot for helping resolve this. I will post an official patch.
>> seems like a fix thats worth having in .26
>
> Did I miss the official post of this patch?
>
> John
I think patch wasn't posted, but it is committed to wireless tree
commit 085fa962fdeb09b17b8052f5f1da353949829e9d
iwlwifi: improve scanning band selection management
Best regards,
Maxim Levitsky
PS: take a look at my bugreport about monitor mode, any ideas?
next prev parent reply other threads:[~2008-06-24 20:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 15:07 [BUG] iwlwifi 3945 works only with disable_hw_scan=1 Maxim Levitsky
2008-06-12 3:28 ` Zhu Yi
2008-06-12 12:13 ` Maxim Levitsky
2008-06-12 13:59 ` [ipw3945-devel] " John W. Linville
2008-06-12 14:19 ` Maxim Levitsky
2008-06-12 20:25 ` Stephen Clark
2008-06-13 7:35 ` Zhu Yi
2008-06-13 8:48 ` Filippo Zangheri
2008-06-13 12:37 ` Tor Håkon Haugen
2008-06-13 13:03 ` John W. Linville
2008-06-13 14:59 ` Tor Håkon Haugen
2008-06-13 15:06 ` Maxim Levitsky
2008-06-13 15:09 ` Tor Håkon Haugen
2008-06-13 20:04 ` Tomas Winkler
2008-06-14 10:00 ` Maxim Levitsky
2008-06-14 16:50 ` Luis R. Rodriguez
2008-06-15 13:42 ` Maxim Levitsky
2008-06-15 13:47 ` Tomas Winkler
2008-06-15 14:12 ` Maxim Levitsky
2008-06-15 15:09 ` Tomas Winkler
2008-06-15 16:47 ` Tomas Winkler
2008-06-16 5:50 ` Maxim Levitsky
2008-06-16 5:52 ` Tomas Winkler
2008-06-16 6:08 ` Maxim Levitsky
2008-06-16 6:46 ` Maxim Levitsky
2008-06-16 7:11 ` Maxim Levitsky
2008-06-16 14:35 ` Dan Williams
2008-06-16 21:41 ` Tomas Winkler
2008-06-18 8:28 ` drago01
2008-06-24 19:47 ` John W. Linville
2008-06-24 20:32 ` Maxim Levitsky [this message]
2008-06-25 5:43 ` Tomas Winkler
-- strict thread matches above, loose matches on Subject: below --
2008-06-11 15:47 Maxim Levitsky
2008-06-12 2:26 ` [ipw3945-devel] " Zhu Yi
2008-06-12 6:42 ` drago01
2008-06-12 7:08 ` Zhu Yi
2008-06-12 12:48 ` Maxim Levitsky
2008-06-12 14:22 ` Maxim Levitsky
2008-06-12 14:26 ` Norbert Preining
2008-06-12 15:02 ` Dan Williams
2008-06-13 2:00 ` Zhu Yi
2008-06-13 14:45 ` Dan Williams
2008-06-16 1:40 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486159C1.2070000@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=drago01@gmail.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).