From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] wifi: mt76: mt7915: remove VHT160 capability on MT7915
Date: Thu, 21 Sep 2023 18:03:23 +0200 [thread overview]
Message-ID: <4862789.31r3eYUQgx@natalenko.name> (raw)
In-Reply-To: <2023092145-luxury-fender-d5b9@gregkh>
[-- Attachment #1: Type: text/plain, Size: 2728 bytes --]
Hello.
On čtvrtek 21. září 2023 9:19:58 CEST Greg Kroah-Hartman wrote:
> On Thu, Sep 21, 2023 at 07:02:41AM +0200, Oleksandr Natalenko wrote:
> > Hello Felix.
> >
> > On středa 26. července 2023 11:17:02 CEST Felix Fietkau wrote:
> > > The IEEE80211_VHT_CAP_EXT_NSS_BW value already indicates support for half-NSS
> > > 160 MHz support, so it is wrong to also advertise full 160 MHz support.
> > >
> > > Fixes: c2f73eacee3b ("wifi: mt76: mt7915: add back 160MHz channel width support for MT7915")
> > > Signed-off-by: Felix Fietkau <nbd@nbd.name>
> > > ---
> > > drivers/net/wireless/mediatek/mt76/mt7915/init.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > > index ee976657bfc3..78552f10b377 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > > @@ -414,7 +414,6 @@ mt7915_init_wiphy(struct mt7915_phy *phy)
> > > if (!dev->dbdc_support)
> > > vht_cap->cap |=
> > > IEEE80211_VHT_CAP_SHORT_GI_160 |
> > > - IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ |
> > > FIELD_PREP(IEEE80211_VHT_CAP_EXT_NSS_BW_MASK, 1);
> > > } else {
> > > vht_cap->cap |=
> > >
> >
> > For some reason this got backported into the stable kernel:
> >
> > ```
> > $ git log --oneline v6.5.2..v6.5.4 -- drivers/net/wireless/mediatek/mt76/mt7915/
> > c43017fbebcc3 wifi: mt76: mt7915: fix power-limits while chan_switch
> > edb1afe042c74 wifi: mt76: mt7915: fix tlv length of mt7915_mcu_get_chan_mib_info
> > 9ec0dec0baea3 wifi: mt76: mt7915: remove VHT160 capability on MT7915
> > 0e61f73e6ebc0 wifi: mt76: mt7915: fix capabilities in non-AP mode
> > 6bce28ce28390 wifi: mt76: mt7915: fix command timeout in AP stop period
> > 7af917d4864c6 wifi: mt76: mt7915: rework tx bytes counting when WED is active
> > feae00c6468ce wifi: mt76: mt7915: rework tx packets counting when WED is active
> > 70bbcc4ad6544 wifi: mt76: mt7915: fix background radar event being blocked
> > ```
> >
> > and this broke my mt7915-based AP.
> >
> > However, if I remove `[VT160]` capability from the hostapd config, things go back to normal. It does seem that 160 MHz still works even.
> >
> > Is this expected?
>
> Is your device also broken in 6.6-rc2?
Yes, the same behaviour is observed with v6.6-rc2:
```
hostapd[1316]: Configured VHT capability [VHT_CAP_SUPP_CHAN_WIDTH_MASK] exceeds max value supported by the driver (1 > 0)
```
while having `[VT160]` in `vht_capab=`.
Thanks.
> thanks,
>
> greg k-h
>
--
Oleksandr Natalenko (post-factum)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-09-21 20:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 9:17 [PATCH 1/3] wifi: mt76: mt7915: remove VHT160 capability on MT7915 Felix Fietkau
2023-07-26 9:17 ` [PATCH 2/3] wifi: mt76: mt7603: fix beacon interval after disabling a single vif Felix Fietkau
2023-07-26 9:17 ` [PATCH 3/3] wifi: mt76: mt7603: fix tx filter/flush function Felix Fietkau
2023-09-21 5:02 ` [PATCH 1/3] wifi: mt76: mt7915: remove VHT160 capability on MT7915 Oleksandr Natalenko
2023-09-21 7:19 ` Greg Kroah-Hartman
2023-09-21 16:03 ` Oleksandr Natalenko [this message]
2023-09-29 11:26 ` Linux regression tracking (Thorsten Leemhuis)
2023-09-22 11:22 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-10-13 13:21 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-09-29 12:59 ` Nicolas Cavallari
2023-09-29 20:36 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4862789.31r3eYUQgx@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).