Re: [PATCH v2] iwl3945: fix up rfkill kconfig and input

[Fabien Crespel <fabien@crespel.net>]

Hello,

After looking at these patches about rfkill for iwlwifi, I fail to see 
the use of the input layer. To me, it seems the input device is 
allocated, registered, and eventually unregistered. But not used at all.

Furthermore, the only key bit set is the KEY_WLAN one, and a wireless 
device driver should NOT issue such events, according to the rfkill 
documentation:

"Most wireless communication device drivers implementing rfkill 
functionality MUST NOT generate these events, and have no reason to 
register themselves with the input layer.  Doing otherwise is a common 
misconception.  There is an API to propagate rfkill status change 
information, and it is NOT the input layer."

So the only drivers that should register to the input layer for such 
events are the laptop platform drivers (thinkpad-acpi, asus-laptop, etc.)

Therefore I would recommend removing the input device completely from 
iwlwifi, and of course the dependency on CONFIG_INPUT.

- Fabien.