From: Dave <kilroyd@googlemail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
linux-wireless@vger.kernel.org, proski@gnu.org,
orinoco-devel@lists.sourceforge.net
Subject: Re: [RFC PATCH 19/19] orinoco: Add MIC on TX and check on RX
Date: Mon, 30 Jun 2008 19:09:37 +0100 [thread overview]
Message-ID: <48692161.9090403@gmail.com> (raw)
In-Reply-To: <1214824008.5507.34.camel@johannes.berg>
Johannes Berg wrote:
> On Sun, 2008-06-29 at 14:56 -0700, Harvey Harrison wrote:
>> On Sat, 2008-06-28 at 19:38 +0100, kilroyd@googlemail.com wrote:
>>> Use the MIC algorithm from the crypto subsystem.
>>>
>>> Signed-off-by: David Kilroy <kilroyd@gmail.com>
>> Any reason not to use the net/mac80211/michael.c implementation?
>
> Yes, depending on mac80211 for a full-mac driver wouldn't be too
> smart :)
I used (a copy of) the mac80211 version in my original implementation because it works within an interrupt, and can be called independently of the mac80211 stack.
However mac80211 doesn't export the MIC implementation, and even if it did, as Johannes says it wouldn't make sense for us to depend on mac80211 just for MIC.
I considered moving the MIC implementation out of mac80211 and exporting it in something like include/linux/ieee80211.h, but I didn't think it was worth it given the MIC implementation in crypto.
Dave.
next prev parent reply other threads:[~2008-06-30 18:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 18:38 [RFC PATCH 00/19] orinoco: WPA for Agere based cards kilroyd
2008-06-28 18:38 ` [RFC PATCH 01/19] orinoco: Add ESSID specific scanning for Agere fw kilroyd
2008-06-28 18:38 ` [RFC PATCH 02/19] orinoco: Update scan translation kilroyd
2008-06-28 18:38 ` [RFC PATCH 03/19] orinoco: Specify all three parameters to every Hermes command kilroyd
2008-06-28 18:38 ` [RFC PATCH 04/19] orinoco: Move EXPORT_SYMBOL declarations next to exported function kilroyd
2008-06-28 18:38 ` [RFC PATCH 05/19] orinoco: Add function to execute Hermes initialisation commands synchronously kilroyd
2008-06-28 18:38 ` [RFC PATCH 06/19] orinoco: Move firmware download functionality into new module kilroyd
2008-06-28 18:38 ` [RFC PATCH 07/19] orinoco: Make firmware download logic more generic kilroyd
2008-06-28 18:38 ` [RFC PATCH 08/19] orinoco: Extend hermes_dld routines for Agere firmware kilroyd
2008-06-28 18:38 ` [RFC PATCH 09/19] orinoco: Invoke firmware download in main driver kilroyd
2008-06-28 18:38 ` [RFC PATCH 10/19] orinoco: Fix transmit for Agere/Lucent with fw 9.x kilroyd
2008-06-28 18:38 ` [RFC PATCH 11/19] orinoco: address checkpatch typedef warning kilroyd
2008-06-28 18:38 ` [RFC PATCH 12/19] orinoco: Use extended Agere scans available on 9.x series firmwares kilroyd
2008-06-28 18:38 ` [RFC PATCH 13/19] orinoco: Don't use boolean parameter to record encoding type kilroyd
2008-06-28 18:38 ` [RFC PATCH 14/19] orinoco: Split wevent work thread from wevent sending kilroyd
2008-06-28 18:38 ` [RFC PATCH 15/19] orinoco: Use a macro to define wireless handlers kilroyd
2008-06-28 18:38 ` [RFC PATCH 16/19] orinoco: Add WE-18 ioctls for WPA kilroyd
2008-06-28 18:38 ` [RFC PATCH 17/19] orinoco: Send association events to userspace kilroyd
2008-06-28 18:38 ` [RFC PATCH 18/19] orinoco: Process bulk of receive interrupt in a tasklet kilroyd
2008-06-28 18:38 ` [RFC PATCH 19/19] orinoco: Add MIC on TX and check on RX kilroyd
2008-06-29 21:56 ` Harvey Harrison
2008-06-30 11:06 ` Johannes Berg
2008-06-30 18:09 ` Dave [this message]
2008-06-30 19:28 ` [RFC PATCH 00/19] orinoco: WPA for Agere based cards John W. Linville
2008-06-30 20:16 ` Dave
2008-08-01 23:49 ` [Orinoco-devel] " Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48692161.9090403@gmail.com \
--to=kilroyd@googlemail.com \
--cc=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).