From: Felix Fietkau <nbd@openwrt.org>
To: linux-wireless@vger.kernel.org
Subject: [PATCH v3] ath9k: fix another endianness issue
Date: Mon, 21 Jul 2008 00:01:37 +0200 [thread overview]
Message-ID: <4883B5C1.7070208@openwrt.org> (raw)
In-Reply-To: <48836863.7090008@openwrt.org>
DMA descriptors must always be accessed in native endianness.
With this patch and my previous series, Atheros AR9160 now
works for me in STA mode (tested on an IXP4xx board, big-endian)
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
sorry, my mail client broke the last one (whitespace crap)
--- a/drivers/net/wireless/ath9k/xmit.c
+++ b/drivers/net/wireless/ath9k/xmit.c
@@ -121,7 +121,7 @@
DPRINTF(sc, ATH_DEBUG_TX_PROC,
"%s: txq depth = %d\n", __func__, txq->axq_depth);
if (txq->axq_link != NULL) {
- *txq->axq_link = cpu_to_le32(bf->bf_daddr);
+ *txq->axq_link = bf->bf_daddr;
DPRINTF(sc, ATH_DEBUG_XMIT,
"%s: link[%u](%p)=%llx (%p)\n",
__func__,
@@ -168,7 +168,7 @@
__func__, txq->axq_qnum,
ito64(bf->bf_daddr), bf->bf_desc);
} else {
- *txq->axq_link = cpu_to_le32(bf->bf_daddr);
+ *txq->axq_link = bf->bf_daddr;
DPRINTF(sc, ATH_DEBUG_XMIT, "%s: link[%u] (%p)=%llx (%p)\n",
__func__,
txq->axq_qnum, txq->axq_link,
--- a/drivers/net/wireless/ath9k/beacon.c
+++ b/drivers/net/wireless/ath9k/beacon.c
@@ -159,7 +159,7 @@
if (!cabq->axq_link)
ath9k_hw_puttxbuf(ah, cabq->axq_qnum, bfmcast->bf_daddr);
else
- *cabq->axq_link = cpu_to_le32(bfmcast->bf_daddr);
+ *cabq->axq_link = bfmcast->bf_daddr;
/* append the private vap mcast list to the cabq */
@@ -688,11 +688,7 @@
if (if_id != ATH_IF_ID_ANY) {
bf = ath_beacon_generate(sc, if_id);
if (bf != NULL) {
- if (bflink != &bfaddr)
- *bflink = cpu_to_le32(
- bf->bf_daddr);
- else
- *bflink = bf->bf_daddr;
+ *bflink = bf->bf_daddr;
bflink = &bf->bf_desc->ds_link;
bc++;
}
next prev parent reply other threads:[~2008-07-20 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 16:31 [PATCH] ath9k: fix another endianness issue Felix Fietkau
2008-07-20 18:42 ` [PATCH v2] " Felix Fietkau
2008-07-20 22:01 ` Felix Fietkau [this message]
2008-07-20 22:26 ` [PATCH v3] " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4883B5C1.7070208@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).