linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "François Valenduc" <francois.valenduc@tvcablenet.be>
To: Patrick McHardy <kaber@trash.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	bugme-daemon@bugzilla.kernel.org, linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965
Date: Wed, 23 Jul 2008 17:58:03 +0200	[thread overview]
Message-ID: <4887550B.2070704@tvcablenet.be> (raw)
In-Reply-To: <488753C6.2090807@trash.net>

Patrick McHardy a =C3=A9crit :
> Fran=C3=A7ois Valenduc wrote:
>> Patrick McHardy a =C3=A9crit :
>>>> I think I know whats happening (Jussi CCed). That commit introduce=
d
>>>> a qdisc_skb_cb, which conflicts with the mac80211 usage of skb->cb=
=2E
>>>> mac80211 seems to expect the CB to survive the qdisc layer, which
>>>> is wrong. One possibility to fix this (or just test my theory)
>>>> would be to make sure they don't clash by adding the struct
>>>> ieee80211_tx_info to qdisc_skb_cb->data. Something like this patch=
=2E
>>>>
>>>
>> I tested your last patch. Unfortunately, I get the following compile=
=20
>> error:
>>
>> In file included from net/mac80211/main.c:11:
>> include/net/mac80211.h: In function =E2=80=98IEEE80211_SKB_CB=E2=80=99=
:
>> include/net/mac80211.h:347: erreur: size of array =E2=80=98type name=
=E2=80=99 is=20
>> negative
>
>
> I was afraid that might happen. This means skb->cb is not large
> enough to hold both the qdisc and the ieee80211 structs.
>
> Just for testing, changing (include/net/mac80211.h):
>
> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>         (sizeof(((struct sk_buff *)0)->cb) - 8)
>
> to
>
> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>         (sizeof(((struct sk_buff *)0)->cb) - 12)
>
> might help to get it to compile. If that doesn't work, try -16.
>
>
That didn't work, neither with -12 or -16.

--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-07-23 15:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-11144-10286@http.bugzilla.kernel.org/>
2008-07-22 10:48 ` [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965 Andrew Morton
2008-07-22 10:52   ` Patrick McHardy
2008-07-23  7:58   ` François Valenduc
2008-07-23  7:59     ` François Valenduc
2008-07-23  8:05     ` Andrew Morton
2008-07-23  9:17       ` François Valenduc
2008-07-23 10:12         ` Patrick McHardy
2008-07-23 11:29           ` François Valenduc
2008-07-23 11:31             ` Patrick McHardy
2008-07-23 11:58               ` François Valenduc
2008-07-23 12:36               ` François Valenduc
2008-07-23 12:44                 ` Patrick McHardy
2008-07-23 12:51                   ` Patrick McHardy
2008-07-23 14:57                     ` François Valenduc
2008-07-23 15:18                       ` Patrick McHardy
2008-07-23 15:19                         ` Patrick McHardy
2008-07-23 15:42                           ` François Valenduc
2008-07-23 15:52                             ` Patrick McHardy
2008-07-23 15:58                               ` François Valenduc [this message]
2008-07-23 15:59                                 ` Patrick McHardy
2008-07-23 16:25                                   ` Patrick McHardy
2008-07-23 21:21                                     ` David Miller
2008-07-24  8:58                                       ` Patrick McHardy
2008-07-24 10:17                                         ` Tomas Winkler
2008-07-24 10:19                                           ` Patrick McHardy
2008-07-24 11:35                                             ` Tomas Winkler
2008-07-24 11:45                                               ` Johannes Berg
2008-07-30 18:04                                                 ` François Valenduc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4887550B.2070704@tvcablenet.be \
    --to=francois.valenduc@tvcablenet.be \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=kaber@trash.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).