Re: [PATCH] rt2x00mac: In error case stop netdev queue, free skb and return NETDEV_TX_OK

[Daniel Wagner <wagi@monom.org>]

Ivo van Doorn wrote:
> On Wednesday 23 July 2008, Daniel Wagner wrote:
>> Ivo van Doorn wrote:
>>> On Wednesday 23 July 2008, Daniel Wagner wrote:
>>>> It is not allowed to use NETDEV_TX_BUSY in tx path anymore.
>>> If not, then why is mac80211 checking and handling the return value
>>> and is tx() still a function returning an int. mac80211 is actually requeueing
>>> the frame when the hardware fails to send it, so why should that be completely blocked?
>> Well, I might be completely wrong here. I got this idea from following mail on netdev:
>> http://marc.info/?l=linux-wireless&m=121025252321824&w=2
> 
> Hmm, well Johannes just indicated that the code I mentioned earlier will be removed,
> in that case I am fine with a patch like this, however with a few adjustments. ;)

Sure :)

> Please make it a decent -E... error code then. Looks far less obscure then -1.

No problemo.

> Also could you make the exit code with
> 
> 	ieee80211_stop_queue(rt2x00dev->hw, qid);
> 	dev_kfree_skb_any(skb);
> 	return NETDEV_TX_OK;
> 
> and exit_fail goto?

yes

daniel