From: Steve Brown <sbrown@cortland.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>,
Tomas Winkler <tomasw@gmail.com>,
Luis Carlos Cobo <luisca@cozybit.com>
Subject: Re: [PATCH 4/4] mac80211: revamp beacon configuration
Date: Sun, 27 Jul 2008 17:51:13 -0400 [thread overview]
Message-ID: <488CEDD1.1000901@cortland.com> (raw)
In-Reply-To: <200807091529.20656.mb@bu3sch.de>
Michael Buesch wrote:
> On Wednesday 09 July 2008 14:40:37 Johannes Berg wrote:
>
>> This patch changes mac80211's beacon configuration handling
>> to never pass skbs to the driver directly but rather always
>> require the driver to use ieee80211_beacon_get(). Additionally,
>> it introduces "change flags" on the config_interface() call
>> to enable drivers to figure out what is changing. Finally, it
>> removes the beacon_update() driver callback in favour of
>> having IBSS beacon delivered by ieee80211_beacon_get() as well.
>>
>> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>> ---
>>
>>
I tested using the current wireless-testing and beacons are gone.
If I revert this patch they reappear.
I'm using the zd1211rw driver on an x86. I also confirmed the missing
beacons using b43, although I haven't tried the reverted patch on that
machine.
I'm not sure what other info to provide. Let me know if anything else is
needed and I'll send post it.
Steve
prev parent reply other threads:[~2008-07-27 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 12:40 [PATCH 0/4] mac80211 interface (config) cleanups Johannes Berg
2008-07-09 12:40 ` [PATCH 1/4] mac80211: make master netdev handling sane Johannes Berg
2008-07-09 12:40 ` [PATCH 2/4] mac80211: revamp virtual interface handling Johannes Berg
2008-07-09 12:40 ` [PATCH 3/4] mac80211: push interface checks down Johannes Berg
2008-07-09 12:40 ` [PATCH 4/4] mac80211: revamp beacon configuration Johannes Berg
2008-07-09 13:29 ` Michael Buesch
2008-07-27 21:51 ` Steve Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488CEDD1.1000901@cortland.com \
--to=sbrown@cortland.com \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luisca@cozybit.com \
--cc=mb@bu3sch.de \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).