From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hin-Tak Leung <hintak.leung@gmail.com>
Cc: John W Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Subject: Re: [PATCH V3] rtl8187: Fix lockups due to concurrent access to config routine
Date: Thu, 31 Jul 2008 21:58:18 -0500 [thread overview]
Message-ID: <48927BCA.1030805@lwfinger.net> (raw)
In-Reply-To: <3ace41890807311929w464c41femf30efc5441830d13@mail.gmail.com>
Hin-Tak Leung wrote:
>
> Thanks for the work. I think we need a few more mutex locks.
I tried two other places: rtl8187_tx() and rtl8187_configure_filter. Both
generated warnings as mac80211 had already had a lock in place. So far, I
haven't seen any candidates, but the code surely needs a thorough audit.
> The one-line message/explanation is a bit mis-worded though. There isn't a
> "lockup" though. I would describe the problem as the driver's internal
> state getting garbbaged. It is probably a performance "feature" that
> routines in either the mac80211 layer or the usb layer returns before
> they are done. (i.e. actions are simply
> queued for near-future to act on). Maybe somebody else can explain this better?
The comment in the code that "the card will stop work until next reset" sounds
as though it locks up. That was why I chose the wording that I did.
Larry
prev parent reply other threads:[~2008-08-01 2:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 0:30 [PATCH V3] rtl8187: Fix lockups due to concurrent access to config routine Larry Finger
2008-08-01 2:29 ` Hin-Tak Leung
2008-08-01 2:58 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48927BCA.1030805@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=hintak.leung@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).