[IWL3945]Fix statistics in monitor mode

[IWL3945]Fix statistics in monitor mode

[Maxim Levitsky]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hi,

I guess it is time for me to add my .02 cents to iwlwifi driver.
Recently I reported a bug about crazy statistics (> 100 quality for 
example) when turning on the monitor interface (this bug actually is 
triggered when card is put in monitor mode, thus shows up when promisc 
mode enabled as well)

It turns out that iwl3945_rx_reply_rx wasn't filling in the statistics 
when running in monitor on, instead a garbage was passed.


Best regards,
	Maxim Levitsky

[-- Attachment #2: 0001-IWL3945-Fix-statistics-in-monitor-mode.patch --]
[-- Type: application/mbox, Size: 1483 bytes --]

Re: [IWL3945]Fix statistics in monitor mode

[Zhu Yi]

On Fri, 2008-08-01 at 13:11 +0300, Maxim Levitsky wrote:
> I guess it is time for me to add my .02 cents to iwlwifi driver.
> Recently I reported a bug about crazy statistics (> 100 quality for 
> example) when turning on the monitor interface (this bug actually is 
> triggered when card is put in monitor mode, thus shows up when promisc
> mode enabled as well)
> 
> It turns out that iwl3945_rx_reply_rx wasn't filling in the statistics
> when running in monitor on, instead a garbage was passed.

Good catch. I'd suggest change 3945 the same way as 4965. That is, move
the iwl_pass_packet_to_mac80211() for MNTR before setting
priv->last_beacon_time, et al. We don't need to update these fields in
monitor mode anyway.

Thanks,
-yi

Re: [ipw3945-devel] [IWL3945]Fix statistics in monitor mode

[Junty Mesmon]

On Sun, Aug 3, 2008 at 11:32 PM, Zhu Yi <yi.zhu@intel.com> wrote:
> On Fri, 2008-08-01 at 13:11 +0300, Maxim Levitsky wrote:
>> I guess it is time for me to add my .02 cents to iwlwifi driver.
>> Recently I reported a bug about crazy statistics (> 100 quality for
>> example) when turning on the monitor interface (this bug actually is
>> triggered when card is put in monitor mode, thus shows up when promisc
>> mode enabled as well)
>>
>> It turns out that iwl3945_rx_reply_rx wasn't filling in the statistics
>> when running in monitor on, instead a garbage was passed.
>
> Good catch. I'd suggest change 3945 the same way as 4965. That is, move
> the iwl_pass_packet_to_mac80211() for MNTR before setting
> priv->last_beacon_time, et al. We don't need to update these fields in
> monitor mode anyway.
>
> Thanks,
> -yi
>

If we can have this data, what reason is their not to have it processed?
     -J

Re: [ipw3945-devel] [IWL3945]Fix statistics in monitor mode

[Zhu Yi]

On Mon, 2008-08-04 at 21:47 -0400, Junty Mesmon wrote:
> If we can have this data, what reason is their not to have it
> processed?

They are not for the monitor mode. Not related frames will mess up the
values for associated STA. This is affect the
associated-while-in-monitor mode.

Thanks,
-yi