From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp8-g19.free.fr ([212.27.42.65]:39553 "EHLO smtp8-g19.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754009AbYHCMfv (ORCPT ); Sun, 3 Aug 2008 08:35:51 -0400 Message-ID: <4895A622.4080104@labri.fr> (sfid-20080803_143555_528470_7D650DA1) Date: Sun, 03 Aug 2008 14:35:46 +0200 From: Brice Goglin MIME-Version: 1.0 To: David Miller CC: netdev@vger.kernel.org, kaber@trash.net, johannes@sipsolutions.net, linux-wireless@vger.kernel.org Subject: Re: [PATCH 11/31]: net: Implement simple sw TX hashing. References: <20080717.051635.124264554.davem@davemloft.net> <4895A19B.5090307@inria.fr> In-Reply-To: <4895A19B.5090307@inria.fr> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Brice Goglin wrote: > So I wonder if we shouldn't change all this into: > 1) simple_tx_hash(skb) returns a big protocol-independent integer (like > a concatenation or basic xor of IP proto/addr/...). It basically just > converts the skb header in something flat and proto-independent. > 2.a) if the device provides select_queue(), we pass this integer to it. > select_queue() either uses the skb headers if it really wants to hash IP > or IPv6 precisely, or uses our protocol-independent integer and just > hash it in a dumb way without caring about the protocol hidden behind it. > 2.b) if there's no select_queue(), we hash the big integer depending on > the number of tx queues > Or (easier) just export simple_tx_hash() to modules so that drivers can rely on it to hash protocols that they have no clue about? Brice