Re: [BUG] IWL3945: Led doesn't blink in monitor mode

[Maxim Levitsky <maximlevitsky@gmail.com>]

Maxim Levitsky wrote:
> After fixing super annoying bug about garbage scan results,
> I noticed smaller bug:
> 
> My wireless leds stop blinking if I enable monitor mode
> (Note that this time this doesn't happen if I enable promisc mode)

Ok, now I understand how its leds work.

the STATISTICS_NOTIFICATION reply from microcode drives all the led 
blinking code. on each such notification the handler decides based on
traffic whenever to turn led solid or blink it.

the handler for 3945 actually counts recieved and transmitted packets!:

> static inline u8 get_blink_rate(struct iwl3945_priv *priv)
> {
> 	int index;
> 	u64 current_tpt = priv->rxtxpackets;
> 	s64 tpt = current_tpt - priv->led_tpt;
> 
> 	if (tpt < 0)
> 		tpt = -tpt;
> 	priv->led_tpt = current_tpt;


in iwl3945-led.c

priv->rxtxpackets is updated each time a packet is recieved/transmitted 
by iwl3945_pass_packet_to_mac80211:

> #ifdef CONFIG_IWL3945_LEDS
> 	if (ieee80211_is_data(hdr->frame_control))
> 		priv->rxtxpackets += len;
> #endif


and iwl3945_build_tx_cmd_basic:

> #ifdef CONFIG_IWL3945_LEDS
> 		priv->rxtxpackets += le16_to_cpu(cmd->cmd.tx.len);
> #endif




now the problem is that as soon as the firmware enters the monitor mode
it stops sending STATISTICS_NOTIFICATION.


So ether I need a way to tell firmware to continue sending this message,
or use a timer instead in monitor mode.

How I can tell the firmware to send STATISTICS_NOTIFICATION in monitor mode?
Intel developers, can you comment on this?

Btw, the led code really should be shared between 3945/4965.

Best regards,
	Maxim Levitsky