linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Philip Langdale <philipl@overt.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	toshiba_acpi@memebeam.org, Ivo van Doorn <ivdoorn@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v2)
Date: Tue, 05 Aug 2008 20:33:23 -0700	[thread overview]
Message-ID: <48991B83.5030607@overt.org> (raw)
In-Reply-To: <20080805212416.GB21738@khazad-dum.debian.net>

Henrique de Moraes Holschuh wrote:
> 
> rfkill-input (now) or userspace (someday) will take care of kicking the
> radio to RFKILL_STATE_UNBLOCKED when (1) issues an event that signals that
> radios don't have to remain blocked.  Maybe this is why you see the WLAN
> going on when you deactivate the radio kill switch?

It's all done behind the scenes I think (it's an ipw2200 device). There's
no rfkill integration from that driver.

> And rfkill-input will soon be enhanced to let the user configure it to do
> something different if he wants.  Your driver doesn't (and shouldn't)
> hardcode policy about it.

Ok, that makes things much easier for me :-) But it means that for now the
user will have to manually kick the device.

> 
> Thanks.  Please take note that rfkill will, right now, try to BLOCK all
> radios on suspend.  That will be changed soon (2.6.28 at the latest), and
> your driver will have to handle blocking radios on suspend directly if it is
> needed for toshibas.

Why is this necessary? Doesn't the radio power down as part of the suspend
process? How would I tell what the hardware is doing?

I'll update the diff when I can.

--phil

  reply	other threads:[~2008-08-06  3:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-02 19:12 [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v2) Philip Langdale
2008-08-03  4:26 ` Henrique de Moraes Holschuh
2008-08-04  1:10   ` Philip Langdale
2008-08-05 21:24     ` Henrique de Moraes Holschuh
2008-08-06  3:33       ` Philip Langdale [this message]
2008-08-06 12:26         ` Henrique de Moraes Holschuh
2008-08-07  4:40       ` Philip Langdale
2008-08-07 13:45         ` Henrique de Moraes Holschuh
2008-08-11 16:41           ` Philip Langdale
2008-08-13  9:29             ` Henrique de Moraes Holschuh
2008-08-14  6:58               ` Philip Langdale
2008-08-16 19:22                 ` Philip Langdale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48991B83.5030607@overt.org \
    --to=philipl@overt.org \
    --cc=hmh@hmh.eng.br \
    --cc=ivdoorn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=toshiba_acpi@memebeam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).