Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Ehud Gavron]

Works fine here.  iperf same results as prior to patch. 

b43-phy0: Broadcom 4311 WLAN found
b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8
b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2

2.6.27-rc2-wl on Ubuntu 8.04 (don't even ask how long it takes to build 
a new kernel and create a debian package and install it...)

Ehud

Michael Buesch wrote:
> This is the first part for the rewrite of the b43 PHY API.
> This is needed in order to make development of N and LP code possible.
>
> PLEASE TEST TEST TEST TEST TEST
>
> Lots of testing on lots of different devices is needed to ensure this
> doesn't introduce regressions due to typos.
> 95% of the patch just moves large parts of the PHY code from one file
> to another. More move-patches will follow.
> 5% of the patch introduces an "ops" based PHY API.
>
> Please test on all of your devices.
>
> http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch
> Apply against wireless-testing.git
>
> (Not attached to the mail, as it is really big)
> _______________________________________________
> Bcm43xx-dev mailing list
> Bcm43xx-dev@lists.berlios.de
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>   

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Larry Finger]

Ehud Gavron wrote:
> Works fine here.  iperf same results as prior to patch.
> b43-phy0: Broadcom 4311 WLAN found
> b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8
> b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2
> 
> 2.6.27-rc2-wl on Ubuntu 8.04 (don't even ask how long it takes to build 
> a new kernel and create a debian package and install it...)

I know, which is one of the reasons I don't use a Debian-based distro. 
I want nothing to do with one whose stated goal is to make it so 
difficult to change the kernel that the users won't do it.

Larry

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Holger Schurig]

> I know, which is one of the reasons I don't use a Debian-based
> distro. I want nothing to do with one whose stated goal is to
> make it so difficult to change the kernel that the users won't
> do it.

Huh?  I use "make install modules_install" from my kernel source 
dir (which I usually get via git) and that works fine, as in 
every distro on earth.

Hehe, but I seldom use distro kernels, not even when I used Red 
Hat or Mandrake in old times :-)

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Michael Buesch]

On Monday 18 August 2008 09:41:10 Holger Schurig wrote:
> > I know, which is one of the reasons I don't use a Debian-based
> > distro. I want nothing to do with one whose stated goal is to
> > make it so difficult to change the kernel that the users won't
> > do it.
> 
> Huh?  I use "make install modules_install" from my kernel source 
> dir (which I usually get via git) and that works fine, as in 
> every distro on earth.

I can only second that.
I simply ignore any distro specific kernel handling and override
the grub/yaboot entries as I desire. I also ignore any rpm or deb
for installing a kernel. I do it this way since the very beginning
and it works fine on debian and non-debian distros.

In general, I do always ignore the packet manager, but install
custom compiled software in a specific directory so it does not
interfere in any way with the distro packets.


-- 
Greetings Michael.

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Michael Buesch]

On Sunday 17 August 2008 21:26:21 Ehud Gavron wrote:
> Works fine here.  iperf same results as prior to patch. 
> 
> b43-phy0: Broadcom 4311 WLAN found
> b43-phy0 debug: Found PHY: Analog 4, Type 2, Revision 8
> b43-phy0 debug: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2

Thanks a lot for testing.

I want to encourage people again to test this patch.
This really needs a lot of testing, because a regression caused by this
would really really be a bad thing.
Even if you think your card was already tested by somebody else, please test
it anyway. There are so many different cards with matching revision numbers
that really are slightly different.

Get wireless-testing.git:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-testing.git

and apply the patch
http://bu3sch.de/patches/wireless-testing/20080816-0023/patches/002-b43-phy-ops.patch

Please test basic features, throughput and longterm stability of the connection.

-- 
Greetings Michael.

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Larry Finger]

Holger Schurig wrote:
> Huh?  I use "make install modules_install" from my kernel source 
> dir (which I usually get via git) and that works fine, as in 
> every distro on earth.
> 
> Hehe, but I seldom use distro kernels, not even when I used Red 
> Hat or Mandrake in old times :-)

I tried that with Ubuntu 8.04 and the resulting kernel wouldn't boot. 
Only when I went through the process of making the ".deb" and 
installing that did the new kernel start properly. I didn't 
investigate it thoroughly as I was only testing one patch - I quickly 
fled back to openSUSE.

Larry

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Larry Finger]

Niklas Wulf wrote:
> I tested this one on my Macbook Pro (3,1).
> 
> # lspci -v
> 0b:00.0 Network controller: Broadcom Corporation BCM4328 802.11a/b/g/n
> (rev 05)
> Subsystem: Apple Computer Inc. Device 008c
> Flags: bus master, fast devsel, latency 0, IRQ 16
> Memory at 97300000 (64-bit, non-prefetchable) [size=16K]
> Capabilities: [40] Power Management version 3
> Capabilities: [58] Vendor Specific Information <?>
> Capabilities: [e8] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0
> Enable-
> Capabilities: [d0] Express Endpoint, MSI 00
> Kernel driver in use: b43-pci-bridge
> Kernel modules: ssb
> 
> It is not recognized by the driver... should it? I don't get a wireless
> device listed in ifconfig nor does dmesg show any device.

No, the driver is not loading correctly because the N PHY is not yet 
supported. The reverse engineering for that device is barely started.

> # ifconfig
> eth0 [...]
> lo [...]
> 
> # dmesg
> [...]
> Broadcom 43xx driver loaded [ Features: PMLR, Firmware-ID: FW13 ]
> [...]
> 
> I'm kind of new to all this wireless stuff. Linuxwireless.org tells me
> 4328 does not work because of missing N Phys support, so I hoped this
> patch would make some difference.

No, that patch is just preparation for what will happen in the future 
when both LP and N PHYs are supported.

> A problem could be the wrong firmware version. OS X says the Chip has
> 4.150.10.__6__ but I can only find 4.150.10.5. Is this important?

Driver 4.150.10.5 is a MIPS driver for Linux. Obviously 4.150.10.6 is 
an OS X driver. I wouldn't expect any difference in the embedded 
firmware between them.

Larry

Re: [PATCH RFT] b43: Rewrite PHY API for N-PHY/LP-PHY -- good on 4311

[Niklas Wulf]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I tested this one on my Macbook Pro (3,1).

# lspci -v
0b:00.0 Network controller: Broadcom Corporation BCM4328 802.11a/b/g/n
(rev 05)
Subsystem: Apple Computer Inc. Device 008c
Flags: bus master, fast devsel, latency 0, IRQ 16
Memory at 97300000 (64-bit, non-prefetchable) [size=16K]
Capabilities: [40] Power Management version 3
Capabilities: [58] Vendor Specific Information <?>
Capabilities: [e8] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0
Enable-
Capabilities: [d0] Express Endpoint, MSI 00
Kernel driver in use: b43-pci-bridge
Kernel modules: ssb

It is not recognized by the driver... should it? I don't get a wireless
device listed in ifconfig nor does dmesg show any device.

# ifconfig
eth0 [...]
lo [...]

# dmesg
[...]
Broadcom 43xx driver loaded [ Features: PMLR, Firmware-ID: FW13 ]
[...]

I'm kind of new to all this wireless stuff. Linuxwireless.org tells me
4328 does not work because of missing N Phys support, so I hoped this
patch would make some difference.

A problem could be the wrong firmware version. OS X says the Chip has
4.150.10.__6__ but I can only find 4.150.10.5. Is this important?

PS: This is my first mail-list-post. Tell me if something's not okay,
please ;-)

Greetings Niklas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIq12JmLNpi6N88eMRApqkAKC+HIt4LDcKcBJVywv5rQsRxpZUcACeI2OF
IoTteOy1itgYu1qtHQfgvbU=
=wM1s
-----END PGP SIGNATURE-----