From: Philip Langdale <philipl@overt.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: LKML <linux-kernel@vger.kernel.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
toshiba_acpi@memebeam.org, Ivo van Doorn <ivdoorn@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v5)
Date: Tue, 19 Aug 2008 20:02:25 -0700 [thread overview]
Message-ID: <48AB8941.4080209@overt.org> (raw)
In-Reply-To: <20080820012936.GE29336@khazad-dum.debian.net>
Henrique de Moraes Holschuh wrote:
>> + toshiba_acpi.rfk_dev->state = RFKILL_STATE_OFF;
>
> Where did that RFKILL_STATE_OFF came from ? :-) Just get rid of it, you
> override it four statements later anyway...
Left over from the first iteration. Now removed and diff updated.
>
> Other than that, the rfkill bits look fine to me.
>
Thanks. Anyone else care to voice an opinion? Should this go in through
wireless-testing then?
--phil
prev parent reply other threads:[~2008-08-20 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 19:21 [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v5) Philip Langdale
2008-08-20 1:29 ` Henrique de Moraes Holschuh
2008-08-20 3:02 ` Philip Langdale [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AB8941.4080209@overt.org \
--to=philipl@overt.org \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshiba_acpi@memebeam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).