[PATCH] mac80211: add missing kernel-doc

[PATCH] mac80211: add missing kernel-doc

[Randy.Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix mac80211 kernel-doc missing struct field:

Warning(linux-2.6.27-rc1-git2//net/mac80211/sta_info.h:329): No description found for parameter 'tid_seq[IEEE80211_QOS_CTL_TID_MASK + 1]'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 net/mac80211/sta_info.h |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.27-rc1-git2.orig/net/mac80211/sta_info.h
+++ linux-2.6.27-rc1-git2/net/mac80211/sta_info.h
@@ -204,6 +204,7 @@ struct sta_ampdu_mlme {
  * @tx_fragments: number of transmitted MPDUs
  * @txrate_idx: TBD
  * @last_txrate_idx: TBD
+ * @tdi_seq: TBD
  * @wme_tx_queue: TBD
  * @ampdu_mlme: TBD
  * @timer_to_tid: identity mapping to ID timers

[PATCH] mac80211: add missing kernel-doc

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix mac80211 kernel-doc missing struct field:

Warning(linux-2.6.27-rc1-git2//net/mac80211/sta_info.h:329): No description found for parameter 'tid_seq[IEEE80211_QOS_CTL_TID_MASK + 1]'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 net/mac80211/sta_info.h |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.27-rc5-git6.orig/net/mac80211/sta_info.h
+++ linux-2.6.27-rc5-git6/net/mac80211/sta_info.h
@@ -204,6 +204,7 @@ struct sta_ampdu_mlme {
  * @tx_fragments: number of transmitted MPDUs
  * @txrate_idx: TBD
  * @last_txrate_idx: TBD
+ * @tid_seq: TBD
  * @wme_tx_queue: TBD
  * @ampdu_mlme: TBD
  * @timer_to_tid: identity mapping to ID timers

[PATCH] mac80211: add missing kernel-doc

[Johannes Berg]

Document the new shutdown member.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Randy, just so you know I've found it already.

 net/mac80211/sta_info.h |    1 +
 1 file changed, 1 insertion(+)

--- wireless-testing.orig/net/mac80211/sta_info.h	2009-02-18 09:53:44.000000000 +0100
+++ wireless-testing/net/mac80211/sta_info.h	2009-02-18 09:55:00.000000000 +0100
@@ -90,6 +90,7 @@ struct tid_ampdu_tx {
  * @buf_size: buffer size for incoming A-MPDUs
  * @timeout: reset timer value (in TUs).
  * @dialog_token: dialog token for aggregation session
+ * @shutdown: this session is being shut down due to STA removal
  */
 struct tid_ampdu_rx {
 	struct sk_buff **reorder_buf;

[PATCH] mac80211: add missing kernel-doc

[Ashok Nagarajan]

Add a few kernel-doc descriptions that were missed
during mesh development.

Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Ashok Nagarajan <ashok@cozybit.com>
---
 net/mac80211/sta_info.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h
index 3bb24a1..672d9c6 100644
--- a/net/mac80211/sta_info.h
+++ b/net/mac80211/sta_info.h
@@ -271,6 +271,9 @@ struct sta_ampdu_mlme {
  * @plink_timer: peer link watch timer
  * @plink_timer_was_running: used by suspend/resume to restore timers
  * @t_offset: timing offset relative to this host
+ * @t_offset_setpoint: reference timing offset of this sta to be used when
+ * 	calculating clockdrift
+ * @ch_type: peer's channel type
  * @debugfs: debug filesystem info
  * @dead: set to true when sta is unlinked
  * @uploaded: set to true when sta is uploaded to the driver
-- 
1.7.5.4

Re: [PATCH] mac80211: add missing kernel-doc

[Randy Dunlap]

On 06/11/2012 10:23 AM, Ashok Nagarajan wrote:

> Add a few kernel-doc descriptions that were missed
> during mesh development.
> 
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Ashok Nagarajan <ashok@cozybit.com>


Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> ---
>  net/mac80211/sta_info.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/sta_info.h b/net/mac80211/sta_info.h
> index 3bb24a1..672d9c6 100644
> --- a/net/mac80211/sta_info.h
> +++ b/net/mac80211/sta_info.h
> @@ -271,6 +271,9 @@ struct sta_ampdu_mlme {
>   * @plink_timer: peer link watch timer
>   * @plink_timer_was_running: used by suspend/resume to restore timers
>   * @t_offset: timing offset relative to this host
> + * @t_offset_setpoint: reference timing offset of this sta to be used when
> + * 	calculating clockdrift
> + * @ch_type: peer's channel type
>   * @debugfs: debug filesystem info
>   * @dead: set to true when sta is unlinked
>   * @uploaded: set to true when sta is uploaded to the driver



-- 
~Randy

Re: [PATCH] mac80211: add missing kernel-doc

[Johannes Berg]

On Mon, 2012-06-11 at 10:23 -0700, Ashok Nagarajan wrote:
> Add a few kernel-doc descriptions that were missed
> during mesh development.

Applied, thanks.

johannes