From: Larry Finger <Larry.Finger@lwfinger.net>
To: gavron@wetwork.net
Cc: Broadcom Wireless <bcm43xx-dev@berlios.de>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Speed enhancement for BCM4306/2
Date: Sat, 06 Sep 2008 18:28:28 -0500 [thread overview]
Message-ID: <48C3121C.9090309@lwfinger.net> (raw)
In-Reply-To: <48C30B3E.2040302@wetwork.net>
gavron@wetwork.net wrote:
> I haven't tried a build yet, but please let me know if I'm on the right
> track.
>
> E
> # diff -uN /tmp/phy.c drivers/net/wireless/b43legacy/phy.c
> --- /tmp/phy.c 2008-09-06 15:13:33.000000000 -0700
> +++ drivers/net/wireless/b43legacy/phy.c 2008-09-06
> 15:54:03.000000000 -0700
> @@ -1010,7 +1010,7 @@
> b43legacy_phy_initb5(dev);
> else
> b43legacy_phy_initb6(dev);
> - if (phy->rev >= 2 || phy->gmode)
> + if (phy->rev >= 2 && phy->gmode)
> b43legacy_phy_inita(dev);
>
> if (phy->rev >= 2) {
> @@ -1021,21 +1021,26 @@
> b43legacy_phy_write(dev, 0x0811, 0x0000);
> b43legacy_phy_write(dev, 0x0015, 0x00C0);
> }
> - if (phy->rev > 5) {
> + if (phy->rev >= 3) {
AFAIK, this change is an error in the specs. I have since changed it.
Sorry I didn't catch it earlier.
Otherwise, this patch seems to be correct. All you need now are the
fixes for b43legacy_phy_initb5() and b43legacy_phy_initb6().
Larry
next prev parent reply other threads:[~2008-09-06 23:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 23:02 Speed enhancement for BCM4306/2 Larry Finger
2008-09-06 4:38 ` gavron
2008-09-06 4:49 ` Larry Finger
2008-09-06 5:04 ` gavron
2008-09-06 10:41 ` Michael Buesch
2008-09-06 15:29 ` Larry Finger
2008-09-06 18:07 ` gavron
2008-09-06 18:11 ` Michael Buesch
2008-09-06 18:30 ` Larry Finger
2008-09-06 22:59 ` gavron
2008-09-06 23:28 ` Larry Finger [this message]
2008-09-06 23:46 ` gavron
2008-09-07 0:18 ` Larry Finger
2008-09-07 0:25 ` gavron
2008-09-07 0:35 ` Larry Finger
2008-09-07 0:41 ` gavron
2008-09-07 0:14 ` gavron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C3121C.9090309@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@berlios.de \
--cc=gavron@wetwork.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).