Re: Speed enhancement for BCM4306/2

[Larry Finger <Larry.Finger@lwfinger.net>]

gavron@wetwork.net wrote:
> 
> 
> Larry Finger wrote:
>> gavron@wetwork.net wrote:
>>> I haven't tried a build yet, but please let me know if I'm on the 
>>> right track.
>>>
>>> E
>>> # diff -uN /tmp/phy.c drivers/net/wireless/b43legacy/phy.c
>>> --- /tmp/phy.c    2008-09-06 15:13:33.000000000 -0700
>>> +++ drivers/net/wireless/b43legacy/phy.c    2008-09-06 
>>> 15:54:03.000000000 -0700
>>> @@ -1010,7 +1010,7 @@
>>>         b43legacy_phy_initb5(dev);
>>>     else
>>>         b43legacy_phy_initb6(dev);
>>> -    if (phy->rev >= 2 || phy->gmode)
>>> +    if (phy->rev >= 2 && phy->gmode)
>>>         b43legacy_phy_inita(dev);
>>>
>>>     if (phy->rev >= 2) {
>>> @@ -1021,21 +1021,26 @@
>>>         b43legacy_phy_write(dev, 0x0811, 0x0000);
>>>         b43legacy_phy_write(dev, 0x0015, 0x00C0);
>>>     }
>>> -    if (phy->rev > 5) {
>>> +    if (phy->rev >= 3) {
>>
>> AFAIK, this change is an error in the specs. I have since changed it. 
>> Sorry I didn't catch it earlier.
>>
>> Otherwise, this patch seems to be correct. All you need now are the 
>> fixes for b43legacy_phy_initb5() and b43legacy_phy_initb6().
>>
>> Larry
> 
> Ok, I've re-looked at the specs and made the appropriate corrections.  
> I've also gone through all of the PHY specs and found one other 
> correction.  It's enclosed below for review.
> 
> Where do I go to find the stuff for ...initb5() and ...initb6()?

That one was also an error in the specs - fixed now.

On the V3 specifications site, click on the RecentChanges button and 
select B5PHY and B6PHY to get the specs for the other routines. I 
rechecked the specs, and all agree with my current (revised) routines.


Larry