From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de,
John Linville <linville@tuxdriver.com>,
LKML <linux-kernel@vger.kernel.org>,
Adel Gadllah <adel.gadllah@gmail.com>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f
Date: Tue, 16 Sep 2008 12:08:48 -0500 [thread overview]
Message-ID: <48CFE820.7010305@lwfinger.net> (raw)
In-Reply-To: <200809161742.15527.mb@bu3sch.de>
Michael Buesch wrote:
> On Tuesday 16 September 2008 16:18:34 Larry Finger wrote:
>> Since commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f entitled
>> "b43/b43legacy: add RFKILL_STATE_HARD_BLOCKED support", the radio LED
>> no longer responds to rfkill switch events.
>>
>> ATM, I do not have a fix, other than reversion of this commit.
>
> It's kind of bogus that it pokes with the software rfkill state
> from within the hardware rfkill handler.
>
> Please revert this patch. The commit log says nothing about
> why this is needed and I don't see a point in overriding the state
> in the rfkill-private data structure from within the driver.
I agree with Michael. From what I know, the only possible reason for
having this state would be if user space could somehow affect the
state of the hardware switch. As the user's finger is the only such
thing, then there is no use for the RFKILL_STATE_HARD_BLOCKED state,
particularly when it breaks LED operations.
Please revert the patch.
Larry
next prev parent reply other threads:[~2008-09-16 17:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 14:18 Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Larry Finger
2008-09-16 15:42 ` Michael Buesch
2008-09-16 17:08 ` Larry Finger [this message]
2008-09-16 19:18 ` Carlos Corbacho
2008-09-16 19:25 ` Michael Buesch
2008-09-16 22:37 ` Henrique de Moraes Holschuh
2008-09-17 14:26 ` Michael Buesch
2008-09-17 14:29 ` John W. Linville
2008-09-17 14:33 ` Michael Buesch
2008-09-16 19:30 ` Larry Finger
2008-09-16 23:32 ` Matthew Garrett
2008-09-17 2:33 ` Henrique de Moraes Holschuh
2008-09-17 2:52 ` Larry Finger
2008-09-17 13:23 ` John W. Linville
2008-09-17 20:07 ` [PATCH] rfkill: update LEDs for all state changes Henrique de Moraes Holschuh
2008-09-17 20:55 ` Larry Finger
2008-09-18 12:43 ` Henrique de Moraes Holschuh
2008-09-18 13:09 ` Larry Finger
2008-09-18 13:18 ` Henrique de Moraes Holschuh
2008-09-18 12:49 ` Ivo van Doorn
2008-09-17 14:22 ` Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Michael Buesch
2008-09-17 14:50 ` Henrique de Moraes Holschuh
2008-09-17 15:28 ` Larry Finger
2008-09-17 15:36 ` Henrique de Moraes Holschuh
2008-09-17 15:47 ` Larry Finger
2008-09-16 19:51 ` Matthew Garrett
2008-09-16 20:34 ` Larry Finger
2008-09-16 21:09 ` Matthew Garrett
2008-09-17 14:19 ` Michael Buesch
2008-09-17 15:18 ` Henrique de Moraes Holschuh
2008-09-17 15:59 ` Michael Buesch
2008-09-17 20:51 ` Tomas Winkler
2008-09-18 13:16 ` Henrique de Moraes Holschuh
2008-09-16 20:44 ` Carlos Corbacho
2008-09-16 21:07 ` Larry Finger
2008-09-16 22:40 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48CFE820.7010305@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=adel.gadllah@gmail.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).