From: Larry Finger <Larry.Finger@lwfinger.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: John W Linville <linville@tuxdriver.com>,
bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC] b43: A patch for control of the radio LED using rfkill
Date: Thu, 18 Sep 2008 08:47:42 -0500 [thread overview]
Message-ID: <48D25BFE.6020708@lwfinger.net> (raw)
In-Reply-To: <200809181519.12366.IvDoorn@gmail.com>
Ivo van Doorn wrote:
> Is dev->phy.radio_on set when mac80211 has send an instruction
> to the driver to enable the radio (start() or config() callback)
> or does it represent the key state in the hardware?
>
> If it is something coming from mac80211, then you do not want
> to send a SOFT_BLOCKED event since that will cause all other radios
> to be switched off simply because the b43 interface has not been
> enabled.
>
> Off course when it represents the key state in the hardware then the
> code would be fine...
The state comes from mac80211 and is set in the config() callback.
What state should be sent at the point when the hardware block is
removed? It seems to me that forcing an UNBLOCKED state gives the
wrong result. Perhaps RFKILL does need to have 4 states so that an
RFKILL_STATE_HW_UNBLOCKED state can be transmitted.
Larry
next prev parent reply other threads:[~2008-09-18 13:47 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 5:07 [RFC] b43: A patch for control of the radio LED using rfkill Larry Finger
2008-09-18 13:19 ` Ivo van Doorn
2008-09-18 13:47 ` Larry Finger [this message]
2008-09-18 13:53 ` Ivo van Doorn
2008-09-18 14:21 ` Henrique de Moraes Holschuh
2008-09-18 14:26 ` Ivo van Doorn
2008-09-18 14:52 ` Henrique de Moraes Holschuh
2008-09-18 15:19 ` [PATCH] rfkill: clarify usage of rfkill_force_state() and rfkill->get_state() Henrique de Moraes Holschuh
2008-09-18 15:24 ` Ivo van Doorn
2008-09-18 16:43 ` Henrique de Moraes Holschuh
2008-09-18 16:45 ` Johannes Berg
2008-09-18 17:32 ` Ivo van Doorn
2008-09-18 17:52 ` Johannes Berg
2008-09-18 18:12 ` Ivo van Doorn
2008-09-18 17:40 ` Ivo van Doorn
2008-09-18 17:41 ` [RFC] b43: A patch for control of the radio LED using rfkill Michael Buesch
2008-09-18 17:37 ` Michael Buesch
2008-09-18 17:48 ` Ivo van Doorn
2008-09-18 17:56 ` Michael Buesch
2008-09-18 18:10 ` Ivo van Doorn
2008-09-18 18:17 ` Michael Buesch
2008-09-18 18:23 ` Ivo van Doorn
2008-09-18 18:34 ` Michael Buesch
2008-09-18 18:36 ` Johannes Berg
2008-09-18 19:23 ` Henrique de Moraes Holschuh
2008-09-18 20:09 ` Ivo van Doorn
2008-09-18 19:08 ` Henrique de Moraes Holschuh
2008-09-18 20:17 ` Ivo van Doorn
2008-09-18 20:28 ` Henrique de Moraes Holschuh
2008-09-18 20:42 ` Ivo van Doorn
2008-09-18 17:34 ` Michael Buesch
2008-09-18 17:42 ` Ivo van Doorn
2008-09-18 17:49 ` Johannes Berg
2008-09-18 18:02 ` Ivo van Doorn
2008-09-18 19:50 ` Henrique de Moraes Holschuh
2008-09-18 17:53 ` Michael Buesch
2008-09-18 18:06 ` Ivo van Doorn
2008-09-18 14:10 ` Henrique de Moraes Holschuh
2008-09-18 14:24 ` Ivo van Doorn
2008-09-18 14:37 ` Henrique de Moraes Holschuh
2008-09-18 15:16 ` Ivo van Doorn
2008-09-18 16:08 ` Henrique de Moraes Holschuh
2008-09-18 16:51 ` Ivo van Doorn
2008-09-18 18:47 ` Henrique de Moraes Holschuh
2008-09-18 19:14 ` Johannes Berg
2008-09-18 20:35 ` Ivo van Doorn
2008-09-18 21:34 ` Henrique de Moraes Holschuh
2008-09-18 17:44 ` Michael Buesch
2008-09-18 17:52 ` Ivo van Doorn
2008-09-18 17:54 ` Johannes Berg
2008-09-18 18:06 ` Ivo van Doorn
2008-09-18 18:13 ` Johannes Berg
2008-09-18 20:10 ` Henrique de Moraes Holschuh
2008-09-18 20:41 ` Ivo van Doorn
2008-09-18 21:36 ` Henrique de Moraes Holschuh
2008-09-19 17:02 ` Ivo van Doorn
2008-09-20 13:10 ` Henrique de Moraes Holschuh
2008-09-20 13:20 ` Ivo van Doorn
2008-09-22 3:01 ` Henrique de Moraes Holschuh
2008-09-22 21:16 ` Michael Buesch
2008-09-18 17:31 ` Michael Buesch
2008-09-18 20:13 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D25BFE.6020708@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).