Re: [RFC V2] b43: A patch for control of the radio LED using rfkill

[Larry Finger <Larry.Finger@lwfinger.net>]

Henrique de Moraes Holschuh wrote:
> 
> The problem is in the "should".
> 
> Maybe something else than b43 (like firmware) changed the radio software
> rfkill bit, and it does not match what mac80211 and userland requested
> anymore.
> 
> What you need to pass to rfkill_force_state() is what the radio is currently
> doing.  So, the state you need to send to rfkill_force_state has to be based
> on the real state of the hardware's "soft switch bit".

The hardware does not have such a bit. Once it is initialized and
mac80211 sends it a packet, it will try to send it. That is true even
if the hardware switch is off. It just will not succeed.

> If the hardware "soft switch" bit is write-only, you have no choice but to
> use the mac80211 value like your V2 patch does, BTW.

Since we have only a read-only hardware switch bit, I think you are
saying that V2 is correct.

Larry