[PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Larry Finger]

An additional BCM4306 has been found with the Bluetooth coexistence
SPROM coding error.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

John,

These devices work with bcm43xx, but not with b43. I'll let you
decide if this is a regression.

Larry
---

Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c
+++ wireless-testing/drivers/net/wireless/b43/main.c
@@ -4545,7 +4545,8 @@ static void b43_sprom_fixup(struct ssb_b
 		    IS_PDEV(pdev, BROADCOM, 0x4320,    DELL, 0x0003) ||
 		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0015) ||
 		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0014) ||
-		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0013))
+		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0013) ||
+		    IS_PDEV(pdev, BROADCOM, 0x4320, MOTOROLA, 0x7010))
 			bus->sprom.boardflags_lo &= ~B43_BFL_BTCOEXIST;
 	}
 }

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Michael Buesch]

On Friday 19 September 2008 21:47:38 Larry Finger wrote:
> An additional BCM4306 has been found with the Bluetooth coexistence
> SPROM coding error.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> John,
> 
> These devices work with bcm43xx, but not with b43. I'll let you
> decide if this is a regression.
> 
> Larry
> ---
> 
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -4545,7 +4545,8 @@ static void b43_sprom_fixup(struct ssb_b
>  		    IS_PDEV(pdev, BROADCOM, 0x4320,    DELL, 0x0003) ||
>  		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0015) ||
>  		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0014) ||
> -		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0013))
> +		    IS_PDEV(pdev, BROADCOM, 0x4320, LINKSYS, 0x0013) ||
> +		    IS_PDEV(pdev, BROADCOM, 0x4320, MOTOROLA, 0x7010))
>  			bus->sprom.boardflags_lo &= ~B43_BFL_BTCOEXIST;
>  	}
>  }
> 
> 

ACK


-- 
Greetings Michael.

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
> > An additional BCM4306 has been found with the Bluetooth coexistence
> > SPROM coding error.

Does anyone actually make laptops that use these bluetooth coexistence
pins? All CSR bluetooth chips do it automatically I'm told, maybe we
should just kill them completely.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Luis R. Rodriguez]

On Sat, Sep 20, 2008 at 1:51 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
>> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
>> > An additional BCM4306 has been found with the Bluetooth coexistence
>> > SPROM coding error.
>
> Does anyone actually make laptops that use these bluetooth coexistence
> pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> should just kill them completely.

Regardless of the wireless card? Or just for bcm?

  Luis

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

On Sat, 2008-09-20 at 13:59 -0700, Luis R. Rodriguez wrote:
> On Sat, Sep 20, 2008 at 1:51 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
> >> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
> >> > An additional BCM4306 has been found with the Bluetooth coexistence
> >> > SPROM coding error.
> >
> > Does anyone actually make laptops that use these bluetooth coexistence
> > pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> > should just kill them completely.
> 
> Regardless of the wireless card? Or just for bcm?

Well just for b43(legacy), but out of curiosity, does any BT chip use
these pins anyway? Well I guess _somebody_ has to buy BCMs BT chips,
but ...

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Luis R. Rodriguez]

On Sat, Sep 20, 2008 at 2:02 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Sat, 2008-09-20 at 13:59 -0700, Luis R. Rodriguez wrote:
>> On Sat, Sep 20, 2008 at 1:51 PM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> > On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
>> >> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
>> >> > An additional BCM4306 has been found with the Bluetooth coexistence
>> >> > SPROM coding error.
>> >
>> > Does anyone actually make laptops that use these bluetooth coexistence
>> > pins? All CSR bluetooth chips do it automatically I'm told, maybe we
>> > should just kill them completely.
>>
>> Regardless of the wireless card? Or just for bcm?
>
> Well just for b43(legacy), but out of curiosity, does any BT chip use
> these pins anyway? Well I guess _somebody_ has to buy BCMs BT chips,
> but ...

BCM BT chips? I thought you said CSR?

  Luis

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Sat, 2008-09-20 at 14:05 -0700, Luis R. Rodriguez wrote:

> >> > Does anyone actually make laptops that use these bluetooth coexistence
> >> > pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> >> > should just kill them completely.
> >>
> >> Regardless of the wireless card? Or just for bcm?
> >
> > Well just for b43(legacy), but out of curiosity, does any BT chip use
> > these pins anyway? Well I guess _somebody_ has to buy BCMs BT chips,
> > but ...
> 
> BCM BT chips? I thought you said CSR?

Well the thing is, BCM wifi chips have these IO pins that tell the BT
chip what the wifi chip is doing. But CSR chips for instance don't care,
they just check what the wifi chip is doing on the antenna. So those
don't use those IO pins.

Hence, I'm wondering if there's any use in the IO pins at all. But they
must have added them for a reason, presumably because their own BT chips
can use those inputs...

Anyway, mostly just idly wondering, since most of the time it works fine
and the EEPROM is actually done right I guess we should keep them on.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Dan Williams]

On Sat, 2008-09-20 at 23:11 +0200, Johannes Berg wrote:
> On Sat, 2008-09-20 at 14:05 -0700, Luis R. Rodriguez wrote:
> 
> > >> > Does anyone actually make laptops that use these bluetooth coexistence
> > >> > pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> > >> > should just kill them completely.
> > >>
> > >> Regardless of the wireless card? Or just for bcm?
> > >
> > > Well just for b43(legacy), but out of curiosity, does any BT chip use
> > > these pins anyway? Well I guess _somebody_ has to buy BCMs BT chips,
> > > but ...
> > 
> > BCM BT chips? I thought you said CSR?
> 
> Well the thing is, BCM wifi chips have these IO pins that tell the BT
> chip what the wifi chip is doing. But CSR chips for instance don't care,
> they just check what the wifi chip is doing on the antenna. So those
> don't use those IO pins.

Marvell SD 8686 have these pins too; I have at least one sample of such
a setup.  Not that I have had time yet to implement it...  but this sort
of thing exists of course.

Dan

> Hence, I'm wondering if there's any use in the IO pins at all. But they
> must have added them for a reason, presumably because their own BT chips
> can use those inputs...
> 
> Anyway, mostly just idly wondering, since most of the time it works fine
> and the EEPROM is actually done right I guess we should keep them on.
> 
> johannes

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Michael Buesch]

On Saturday 20 September 2008 23:02:55 Johannes Berg wrote:
> On Sat, 2008-09-20 at 13:59 -0700, Luis R. Rodriguez wrote:
> > On Sat, Sep 20, 2008 at 1:51 PM, Johannes Berg
> > <johannes@sipsolutions.net> wrote:
> > > On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
> > >> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
> > >> > An additional BCM4306 has been found with the Bluetooth coexistence
> > >> > SPROM coding error.
> > >
> > > Does anyone actually make laptops that use these bluetooth coexistence
> > > pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> > > should just kill them completely.
> > 
> > Regardless of the wireless card? Or just for bcm?
> 
> Well just for b43(legacy), but out of curiosity, does any BT chip use
> these pins anyway? Well I guess _somebody_ has to buy BCMs BT chips,
> but ...

The wireless card for the powermac uses it.
I have one. (But I never tried whether it works correctly. I'm not sure
how to, anyway)

-- 
Greetings Michael.

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Larry Finger]

Johannes Berg wrote:
> On Sat, 2008-09-20 at 17:44 +0200, Michael Buesch wrote:
>> On Friday 19 September 2008 21:47:38 Larry Finger wrote:
>>> An additional BCM4306 has been found with the Bluetooth coexistence
>>> SPROM coding error.
> 
> Does anyone actually make laptops that use these bluetooth coexistence
> pins? All CSR bluetooth chips do it automatically I'm told, maybe we
> should just kill them completely.

I don't know, but I really wouldn't want to blindly kill bluetooth
coexistence. After all, most cards have their SPROMs programmed
correctly. Only the PCI-versions of the BCM4306 and the ASUS BCM4318
seem to have the problem.

I have been working the openSUSE and Ubuntu support forums, which is
where I have been getting these new devices to add to the work-around.

Larry

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

On Sat, 2008-09-20 at 16:08 -0500, Larry Finger wrote:

> I don't know, but I really wouldn't want to blindly kill bluetooth
> coexistence. After all, most cards have their SPROMs programmed
> correctly. Only the PCI-versions of the BCM4306 and the ASUS BCM4318
> seem to have the problem.

Yeah, true, it's mostly fine. Maybe we're missing something in the specs
that makes the original driver work? Otherwise, I suspect they'd be
getting these cards back in bunches...

> I have been working the openSUSE and Ubuntu support forums, which is
> where I have been getting these new devices to add to the work-around.

Yeah, I still wonder where you get the patience to deal with support
forums, but I think everybody very much appreciates that :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] b43: Fix Bluetooth coexistence SPROM coding error for Motorola 7010 variant of BCM4306

[Larry Finger]

Johannes Berg wrote:
> Yeah, I still wonder where you get the patience to deal with support
> forums, but I think everybody very much appreciates that :)

For the past month, we have been providing day care for our 22-month
old grandson. That pretty much precludes any project that requires
large chunks of time to think a problem through. The support forums
only take a few minutes in each instance. Yes, it gets frustrating at
times. The worst has been when it took 4 tries for a user to get the
command '/sbin/lspci -nnv' entered correctly, and he got it only when
someone else gave him every character that had to be typed.

Larry