From: Randy Dunlap <randy.dunlap@oracle.com>
To: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Cc: linville@tuxdriver.com, akpm <akpm@linux-foundation.org>
Subject: [PATCH -mm] rt2x00: fix Kconfig dependencies
Date: Mon, 22 Sep 2008 16:29:07 -0700 [thread overview]
Message-ID: <48D82A43.7040604@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
If RT2X00=y but RFKILL=m, these build errors happen:
(.text+0x7c7d6): undefined reference to `rfkill_free'
rt2x00rfkill.c:(.text+0x7c830): undefined reference to `rfkill_force_state'
(.text+0x7c88d): undefined reference to `rfkill_unregister'
(.text+0x7c8cd): undefined reference to `rfkill_register'
(.text+0x7ca1a): undefined reference to `rfkill_allocate'
so restrict RT2X00's RFKILL config level to that of the main RFKILL option.
This is done by making the former a tristate instead of a bool
config option.
If RT2X00=y but LEDS_CLASS=m, these build errors happen:
(.text+0x11859f): undefined reference to `led_classdev_resume'
(.text+0x1185b3): undefined reference to `led_classdev_resume'
(.text+0x1185c7): undefined reference to `led_classdev_resume'
(.text+0x1185e4): undefined reference to `led_classdev_suspend'
(.text+0x1185f8): undefined reference to `led_classdev_suspend'
(.text+0x11860c): undefined reference to `led_classdev_suspend'
rt2x00leds.c:(.text+0x118620): undefined reference to `led_classdev_unregister'
rt2x00leds.c:(.text+0x118695): undefined reference to `led_classdev_register'
so restrict RT2X00's LEDS config level to that of the main LEDS_CLASS option.
This is done by making the former a tristate instead of a bool
config option.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/wireless/rt2x00/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- mmotm-2008-0922-0136.orig/drivers/net/wireless/rt2x00/Kconfig
+++ mmotm-2008-0922-0136/drivers/net/wireless/rt2x00/Kconfig
@@ -38,13 +38,13 @@ config RT2X00_LIB_CRYPTO
depends on RT2X00_LIB
config RT2X00_LIB_RFKILL
- boolean
+ tristate
depends on RT2X00_LIB
depends on RFKILL
default y
config RT2X00_LIB_LEDS
- boolean
+ tristate
depends on RT2X00_LIB
depends on NEW_LEDS
depends on LEDS_CLASS
next reply other threads:[~2008-09-22 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 23:29 Randy Dunlap [this message]
2008-09-23 7:07 ` [PATCH -mm] rt2x00: fix Kconfig dependencies Ivo van Doorn
2008-09-23 16:25 ` Randy Dunlap
2008-09-23 17:51 ` Ivo van Doorn
2008-09-23 21:03 ` Randy Dunlap
2008-09-23 21:57 ` Larry Finger
2008-09-23 22:09 ` Ivo van Doorn
2008-09-23 22:30 ` Randy Dunlap
2008-09-23 22:45 ` Ivo van Doorn
2008-09-28 9:03 ` Gertjan van Wingerde
2008-09-28 9:24 ` Ivo van Doorn
2008-09-28 13:16 ` Gertjan van Wingerde
2008-09-28 14:12 ` Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D82A43.7040604@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).