From: Jiri Slaby <jirislaby@gmail.com>
To: Gregory Nietsky <gregory@dnstelecom.co.za>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath5k-devel@venema.h4ckr.net
Subject: Re: [ath5k-devel] [PATCH 1/1] Ath5k: add AP mode
Date: Sun, 28 Sep 2008 18:14:27 +0200 [thread overview]
Message-ID: <48DFAD63.4010007@gmail.com> (raw)
In-Reply-To: <48DF6535.8080407@dnstelecom.co.za>
On 09/28/2008 01:06 PM, Gregory Nietsky wrote:
>
> Quick Observation ...
>
> it appears IEEE80211 types have been replaced with NL80211 types in
> kernel ... so would the following not be more correct and is opmode not
> defined as
>
> struct ath5k_softc {
> ....
> enum nl80211_iftype opmode;
> .....
It already is.
> @@ -2130,14 +2129,15 @@ ath5k_beacon_config(struct ath5k_softc *sc)
>
> sc->imask |= AR5K_INT_SWBA;
>
> - if (ath5k_hw_hasveol(ah)) {
> - spin_lock(&sc->block);
> - ath5k_beacon_send(sc);
> - spin_unlock(&sc->block);
> - }
> + if (sc->opmode == NL80211_IFTYPE_ADHOC) {
> + if (ath5k_hw_hasveol(ah)) {
> + spin_lock(&sc->block);
> + ath5k_beacon_send(sc);
> + spin_unlock(&sc->block);
> + }
> + } else
> + ath5k_beacon_update_timers(sc, -1);
Yeah, that's the correct hunk, thanks. I sent a non-updated version.
prev parent reply other threads:[~2008-09-28 16:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-27 12:48 [PATCH 1/1] Ath5k: add AP mode Jiri Slaby
2008-09-28 10:44 ` [ath5k-devel] " Gregory Nietsky
2008-09-28 11:06 ` Gregory Nietsky
2008-09-28 16:14 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DFAD63.4010007@gmail.com \
--to=jirislaby@gmail.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=gregory@dnstelecom.co.za \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).