Re: [RFC/T] b43: to few loop tries in do_dummy_tx

[gavron@wetwork.net]

Michael Buesch wrote:
> On Tuesday 30 September 2008 07:50:34 Peter Stuge wrote:
>   
>> Larry Finger wrote:
>>     
>>>> Which specs?
>>>>         
>>> The ones generated by the reverse engineers. See
>>> http://bcm-v4.sipsolutions.net/.
>>>       
>> Nice work, but as it's a spec of another driver implementation rather
>> than hardware (or even the firmware API) I don't think it should be
>> so authoritative. If other values are clearly better why not use
>> them?
>>     
>
> What crap are you smoking?
> The b43 and b43-legacy driver are _based_ on these specifications.
> There are no other specs available.
>
>   
If I understand him correctly he's suggesting that there could be BETTER 
values than those used by the reference driver.  In other words, yes, 
B43/B43-Legacy are based on the RE of the Windows driver but perhaps 
there are better values that improve behavior beyond that of the 
original driver.

He didn't say the following but I will: It's also true that there are 
edge cases that RE won't catch without repeated arduous testing in 
adverse conditions, and there may be code in the reference driver that 
will therefore won't end up in the specs.  This means that behavioral 
improvements and/or performance gains in B43/B43-Legacy that can be 
gained without getting into those edge cases are worthy of consideration 
(or maybe specially labeled code).

Just my two farthings worth.

E

-- 
Legal Disclaimer that you are now contractually bound to under all laws with no recourse:
http://attrition.org/security/rants/z/disclaimers.html