Re: [PATCH 2/4] mac80211: add multi-rate retry support

[Felix Fietkau <nbd@openwrt.org>]

Johannes Berg wrote:
> On Tue, 2008-10-07 at 19:13 +0200, Felix Fietkau wrote:
>> Johannes Berg wrote:
>> > On Sun, 2008-10-05 at 18:04 +0200, Felix Fietkau wrote:
>> >> This patch adjusts the rate control API to allow multi-rate retry
>> >> if supported by the driver. The ieee80211_hw struct specifies how
>> >> many alternate rate selections the driver supports.
>> > 
>> > Don't those drivers that announce supporting max_altrates = 1 have to
>> > update the status for alternative rates too? Also, should
>> > max_altrate_tries == 0 indicate that that is fixed?
>> IMHO yes.
> Should we document that?
Maybe ;)

>> The IEEE80211_TX_CTL_RATE_CTRL_PROBE flag is used to tell the tx_status
>> function that there is a sampling rate in the second MRR stage, so that
>> it can update the sampling counter accordingly, in case the sampling rate
>> actually got used.
> So if I read that correctly you're saying it's not part of the driver
> API but just something to be preserved from tx to tx-status. Can you
> document that in the header file too please?
Will send a new patch updating the docs soon. Should that hint apply to
only this particular flag or the whole flags struct member?

- Felix