From: Dave <kilroyd@googlemail.com>
To: Andrey Borzenkov <arvidjaar@newmail.ru>
Cc: Dave <kilroyd@googlemail.com>,
orinoco-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter
Date: Fri, 10 Oct 2008 18:03:48 +0100 [thread overview]
Message-ID: <48EF8AF4.1040900@gmail.com> (raw)
In-Reply-To: <200810101141.38929.arvidjaar@newmail.ru>
Andrey Borzenkov wrote:
> On Friday 10 October 2008, Dave wrote:
>> Thanks for identifying the problem. The Agere case looks good - a few suggestions for the Symbol case though:
>
> Updated patch attached
>
>>
>> But you absolutely have to kfree(pda) here.
>
> Yes, I forgot; sorry.
>
>> Dan Williams wrote:
>>> maybe you should not use priv->pda_size but
>>> #define SYMBOL_PDA_SIZE 256 and use that for the hermes_read_pda()
>>> length just to ensure the patched code is functionally the same as
>>> before the patch.
>> Using fw->pda_size should be fine. The value comes from a const static, set to 0x100 for Symbol.
>>
>
> Actually it allocated 512 byte before. Should it probably be set to 0x200?
You're right. pda_size is supposed to be the maximum size of the PDA (in bytes) that we expect with the firmware. It should be set to 0x200.
I've scanned the rest of the patch and it looks good.
Dave.
next prev parent reply other threads:[~2008-10-10 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 13:22 rc9 + orinoco WPA patchset: BUG: scheduling while atomic loading firmware with PCMCIA adapter Andrey Borzenkov
2008-10-09 13:31 ` Matthew Wilcox
2008-10-09 15:59 ` Andrey Borzenkov
2008-10-09 16:06 ` Dan Williams
2008-10-09 16:13 ` Andrey Borzenkov
2008-10-09 19:21 ` Andrey Borzenkov
2008-10-09 19:40 ` Dan Williams
2008-10-09 22:47 ` Dave
2008-10-10 7:41 ` Andrey Borzenkov
2008-10-10 17:03 ` Dave [this message]
2008-10-10 17:14 ` Andrey Borzenkov
2008-10-10 17:16 ` Dave
2008-10-10 17:26 ` Andrey Borzenkov
2008-10-10 21:19 ` Dave
2008-10-17 20:44 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EF8AF4.1040900@gmail.com \
--to=kilroyd@googlemail.com \
--cc=arvidjaar@newmail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=orinoco-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).